Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize memory footprint of CS schemas #12593

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

swalrus1
Copy link
Collaborator

Changelog entry

Clean up fields of TIndexInfo to reduce memory footprint

Changelog category

  • Improvement

Additional information

...

@swalrus1 swalrus1 linked an issue Dec 13, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 08:42:17 UTC Pre-commit check linux-x86_64-release-asan for f50e785 has started.
2024-12-13 08:42:28 UTC Artifacts will be uploaded here
2024-12-13 08:45:31 UTC ya make is running...

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 08:42:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for f50e785 has started.
2024-12-13 08:42:30 UTC Artifacts will be uploaded here
2024-12-13 08:45:42 UTC ya make is running...

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 09:44:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2600062 has started.
2024-12-13 09:44:58 UTC Artifacts will be uploaded here
2024-12-13 09:48:08 UTC ya make is running...
2024-12-13 09:56:05 UTC Check cancelled

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 09:46:39 UTC Pre-commit check linux-x86_64-release-asan for 2600062 has started.
2024-12-13 09:46:51 UTC Artifacts will be uploaded here
2024-12-13 09:50:04 UTC ya make is running...
2024-12-13 09:55:56 UTC Check cancelled

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 09:56:39 UTC Pre-commit check linux-x86_64-release-asan for 3bcca35 has started.
2024-12-13 09:56:43 UTC Artifacts will be uploaded here
2024-12-13 09:59:20 UTC Check cancelled

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 09:57:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3bcca35 has started.
2024-12-13 09:57:44 UTC Artifacts will be uploaded here
2024-12-13 09:59:20 UTC Check cancelled

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 10:03:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for ce7ff93 has started.
2024-12-13 10:03:30 UTC Artifacts will be uploaded here
2024-12-13 10:06:31 UTC ya make is running...
🟡 2024-12-13 11:11:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32525 29559 0 26 2822 118

2024-12-13 11:14:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-13 11:26:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
963 (only retried tests) 833 0 20 0 110

2024-12-13 11:26:43 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-13 11:38:26 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
810 (only retried tests) 681 0 20 0 109

🟢 2024-12-13 11:38:44 UTC Build successful.
🟢 2024-12-13 11:39:07 UTC ydbd size 2.1 GiB changed* by -77.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: be585b6 merge: ce7ff93 diff diff %
ydbd size 2 256 569 224 Bytes 2 256 490 384 Bytes -77.0 KiB -0.003%
ydbd stripped size 484 006 288 Bytes 483 990 928 Bytes -15.0 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 10:03:54 UTC Pre-commit check linux-x86_64-release-asan for ce7ff93 has started.
2024-12-13 10:04:06 UTC Artifacts will be uploaded here
2024-12-13 10:07:23 UTC ya make is running...
🟡 2024-12-13 11:21:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15112 15024 0 34 8 46

🟢 2024-12-13 11:22:18 UTC Build successful.
🟢 2024-12-13 11:22:44 UTC ydbd size 3.6 GiB changed* by -193.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: be585b6 merge: ce7ff93 diff diff %
ydbd size 3 899 129 432 Bytes 3 898 930 896 Bytes -193.9 KiB -0.005%
ydbd stripped size 1 366 842 544 Bytes 1 366 800 752 Bytes -40.8 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 12:12:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2b07ae6 has started.
2024-12-13 12:12:25 UTC Artifacts will be uploaded here
2024-12-13 12:15:36 UTC ya make is running...
🟡 2024-12-13 13:26:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32533 29593 0 3 2823 114

2024-12-13 13:28:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-13 13:41:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
764 (only retried tests) 655 0 0 0 109

🟢 2024-12-13 13:41:28 UTC Build successful.
🟢 2024-12-13 13:41:46 UTC ydbd size 2.1 GiB changed* by -72.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ee3d7ef merge: 2b07ae6 diff diff %
ydbd size 2 258 128 192 Bytes 2 258 053 568 Bytes -72.9 KiB -0.003%
ydbd stripped size 484 292 176 Bytes 484 280 976 Bytes -10.9 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 12:12:22 UTC Pre-commit check linux-x86_64-release-asan for 2b07ae6 has started.
2024-12-13 12:12:33 UTC Artifacts will be uploaded here
2024-12-13 12:15:43 UTC ya make is running...
🟡 2024-12-13 13:38:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15116 15042 0 17 8 49

🟢 2024-12-13 13:39:20 UTC Build successful.
🟢 2024-12-13 13:39:45 UTC ydbd size 3.6 GiB changed* by -193.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ee3d7ef merge: 2b07ae6 diff diff %
ydbd size 3 902 392 816 Bytes 3 902 194 248 Bytes -193.9 KiB -0.005%
ydbd stripped size 1 367 951 536 Bytes 1 367 909 744 Bytes -40.8 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 marked this pull request as ready for review December 16, 2024 07:10
@swalrus1 swalrus1 requested a review from a team as a code owner December 16, 2024 07:10
@swalrus1 swalrus1 force-pushed the optimize-index-fields branch from 33ad8ad to 7eabf82 Compare December 16, 2024 14:55
Copy link

github-actions bot commented Dec 16, 2024

2024-12-16 14:58:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 03916c5 has started.
2024-12-16 14:58:48 UTC Artifacts will be uploaded here
2024-12-16 15:01:48 UTC ya make is running...
2024-12-16 15:05:48 UTC Check cancelled

Copy link

github-actions bot commented Dec 16, 2024

2024-12-16 14:59:08 UTC Pre-commit check linux-x86_64-release-asan for 03916c5 has started.
2024-12-16 14:59:20 UTC Artifacts will be uploaded here
2024-12-16 15:02:24 UTC ya make is running...
2024-12-16 15:05:51 UTC Check cancelled

Copy link

github-actions bot commented Dec 16, 2024

2024-12-16 15:09:10 UTC Pre-commit check linux-x86_64-release-asan for e773674 has started.
2024-12-16 15:09:53 UTC Artifacts will be uploaded here
2024-12-16 15:13:33 UTC ya make is running...
🟡 2024-12-16 16:35:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13810 13727 0 29 5 49

🟢 2024-12-16 16:36:43 UTC Build successful.
🟢 2024-12-16 16:37:08 UTC ydbd size 3.6 GiB changed* by -177.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0a53ed1 merge: e773674 diff diff %
ydbd size 3 894 504 584 Bytes 3 894 323 264 Bytes -177.1 KiB -0.005%
ydbd stripped size 1 363 332 912 Bytes 1 363 296 240 Bytes -35.8 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 16, 2024

2024-12-16 15:10:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for e773674 has started.
2024-12-16 15:10:40 UTC Artifacts will be uploaded here
2024-12-16 15:13:40 UTC ya make is running...
🟡 2024-12-16 16:19:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30723 27771 0 7 2829 116

2024-12-16 16:22:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-16 16:34:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 62 0 0 0 111

🟢 2024-12-16 16:34:42 UTC Build successful.
🟢 2024-12-16 16:35:01 UTC ydbd size 2.1 GiB changed* by -68.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0a53ed1 merge: e773674 diff diff %
ydbd size 2 253 924 832 Bytes 2 253 854 936 Bytes -68.3 KiB -0.003%
ydbd stripped size 482 944 496 Bytes 482 930 288 Bytes -13.9 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 merged commit 99fdf00 into ydb-platform:main Dec 17, 2024
10 checks passed
@swalrus1 swalrus1 deleted the optimize-index-fields branch December 17, 2024 10:07
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize memory usage by fields of portion metadata on CS
2 participants