Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont use default columns for merger #12380

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

Copy link

github-actions bot commented Dec 7, 2024

2024-12-07 13:36:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for a54657d has started.
2024-12-07 13:36:33 UTC Artifacts will be uploaded here
2024-12-07 13:39:31 UTC ya make is running...
🟢 2024-12-07 14:43:13 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31086 28258 0 0 2720 108

🟢 2024-12-07 14:45:44 UTC Build successful.
🟢 2024-12-07 14:46:02 UTC ydbd size 2.5 GiB changed* by -8.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 751da8a merge: a54657d diff diff %
ydbd size 2 699 385 352 Bytes 2 699 377 032 Bytes -8.1 KiB -0.000%
ydbd stripped size 483 518 032 Bytes 483 516 560 Bytes -1.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 7, 2024

2024-12-07 13:38:05 UTC Pre-commit check linux-x86_64-release-asan for a54657d has started.
2024-12-07 13:38:15 UTC Artifacts will be uploaded here
2024-12-07 13:41:18 UTC ya make is running...
🟡 2024-12-07 14:57:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13716 13637 0 28 8 43

🟢 2024-12-07 14:58:11 UTC Build successful.
🟢 2024-12-07 14:58:38 UTC ydbd size 4.9 GiB changed* by -23.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 751da8a merge: a54657d diff diff %
ydbd size 5 305 899 064 Bytes 5 305 874 904 Bytes -23.6 KiB -0.000%
ydbd stripped size 1 365 606 032 Bytes 1 365 605 840 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 8, 2024 04:56
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner December 8, 2024 04:56
@ivanmorozov333 ivanmorozov333 merged commit 717a5a0 into ydb-platform:main Dec 9, 2024
11 checks passed
@ivanmorozov333 ivanmorozov333 deleted the dont_restore_absent_columns_on_compaction_merge branch December 9, 2024 09:50
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants