Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnableImmediateWritingOnBulkUpsert by default #12272

Conversation

zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Dec 4, 2024

Changelog entry Use immediate write for BulkUpsert

Changelog category

  • Experimental feature

Copy link

github-actions bot commented Dec 4, 2024

2024-12-04 08:05:11 UTC Pre-commit check linux-x86_64-release-asan for 9358ea0 has started.
2024-12-04 08:05:40 UTC Artifacts will be uploaded here
2024-12-04 08:09:31 UTC ya make is running...
🟡 2024-12-04 09:47:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15213 15131 0 26 7 49

🟢 2024-12-04 09:48:24 UTC Build successful.
🟢 2024-12-04 09:48:53 UTC ydbd size 4.9 GiB changed* by +288 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d6a279e merge: 9358ea0 diff diff %
ydbd size 5 307 983 192 Bytes 5 307 983 480 Bytes +288 Bytes +0.000%
ydbd stripped size 1 365 523 472 Bytes 1 365 523 344 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 4, 2024

2024-12-04 08:06:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9358ea0 has started.
2024-12-04 08:06:30 UTC Artifacts will be uploaded here
2024-12-04 08:09:57 UTC ya make is running...
🟡 2024-12-04 09:49:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32666 29824 0 6 2723 113

2024-12-04 09:51:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-04 10:03:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
728 (only retried tests) 622 0 0 0 106

🟢 2024-12-04 10:03:39 UTC Build successful.
🟢 2024-12-04 10:04:13 UTC ydbd size 2.5 GiB changed* by +304 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d6a279e merge: 9358ea0 diff diff %
ydbd size 2 701 651 032 Bytes 2 701 651 336 Bytes +304 Bytes +0.000%
ydbd stripped size 483 580 528 Bytes 483 580 528 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 4, 2024

2024-12-04 12:18:34 UTC Pre-commit check linux-x86_64-release-asan for ec68e19 has started.
2024-12-04 12:19:14 UTC Artifacts will be uploaded here
2024-12-04 12:23:28 UTC ya make is running...
🟡 2024-12-04 14:04:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15215 15127 0 31 10 47

🟢 2024-12-04 14:05:35 UTC Build successful.
🟢 2024-12-04 14:06:08 UTC ydbd size 4.9 GiB changed* by -400 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d7df471 merge: ec68e19 diff diff %
ydbd size 5 308 357 800 Bytes 5 308 357 400 Bytes -400 Bytes -0.000%
ydbd stripped size 1 365 621 584 Bytes 1 365 621 520 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 4, 2024

2024-12-04 12:19:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for ec68e19 has started.
2024-12-04 12:20:03 UTC Artifacts will be uploaded here
2024-12-04 12:23:27 UTC ya make is running...
🟢 2024-12-04 13:56:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32668 29836 0 0 2721 111

🟢 2024-12-04 13:58:47 UTC Build successful.
🟢 2024-12-04 13:59:03 UTC ydbd size 2.5 GiB changed* by +128 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: d7df471 merge: ec68e19 diff diff %
ydbd size 2 701 815 712 Bytes 2 701 815 840 Bytes +128 Bytes +0.000%
ydbd stripped size 483 605 200 Bytes 483 605 200 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny merged commit d099a43 into ydb-platform:main Dec 5, 2024
11 checks passed
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
Conflicts:
	ydb/core/protos/feature_flags.proto
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
Conflicts:
	ydb/core/protos/feature_flags.proto
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
Conflicts:
	ydb/core/protos/feature_flags.proto
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Conflicts:
	ydb/core/protos/feature_flags.proto
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 31, 2025
Conflicts:
	ydb/core/kqp/ut/common/kqp_ut_common.h
	ydb/core/kqp/ut/olap/write_ut.cpp
	ydb/core/protos/feature_flags.proto
	ydb/core/testlib/test_client.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants