Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CompareRanges #12043

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Fix CompareRanges #12043

merged 5 commits into from
Nov 28, 2024

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Nov 27, 2024 •
edited
Loading

Changelog entry

Fix Ranges Compare.

Bug: CompareRanges([1, 10), [10, 100)) returned 0.

Changelog category

  • Bugfix

Additional information

...

ssmike
ssmike previously approved these changes Nov 27, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 10:29:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for a4e991b has started.
⚪ 2024-11-27 10:29:33 UTC Artifacts will be uploaded here
⚪ 2024-11-27 10:32:42 UTC ya make is running...
⚫ 2024-11-27 10:42:27 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 10:29:35 UTC Pre-commit check linux-x86_64-release-asan for a4e991b has started.
⚪ 2024-11-27 10:29:46 UTC Artifacts will be uploaded here
⚪ 2024-11-27 10:33:05 UTC ya make is running...
⚫ 2024-11-27 10:42:27 UTC Check cancelled

@nikvas0 nikvas0 requested a review from snaury November 27, 2024 10:29
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 10:44:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 38705e2 has started.
⚪ 2024-11-27 10:44:16 UTC Artifacts will be uploaded here
⚪ 2024-11-27 10:47:28 UTC ya make is running...
🟡 2024-11-27 12:15:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32355 29163 0 205 2862 125

⚪ 2024-11-27 12:18:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-27 12:44:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1733 (only retried tests) 1397 0 203 26 107

⚪ 2024-11-27 12:44:31 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-27 13:11:42 UTC ydbd size 2.5 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 423f428 merge: 38705e2 diff diff %
ydbd size 2 694 260 368 Bytes 2 694 260 368 Bytes 0 Bytes 0.000%
ydbd stripped size 482 109 360 Bytes 482 109 360 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-11-27 13:11:44 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 10:44:22 UTC Pre-commit check linux-x86_64-release-asan for 38705e2 has started.
⚪ 2024-11-27 10:44:33 UTC Artifacts will be uploaded here
⚪ 2024-11-27 10:47:41 UTC ya make is running...
🟡 2024-11-27 12:23:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15013 14685 0 171 106 51

🟢 2024-11-27 12:24:18 UTC Build successful.
🟢 2024-11-27 12:24:46 UTC ydbd size 4.9 GiB changed* by +1.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 423f428 merge: 38705e2 diff diff %
ydbd size 5 293 440 336 Bytes 5 293 441 584 Bytes +1.2 KiB +0.000%
ydbd stripped size 1 360 850 832 Bytes 1 360 851 280 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 changed the title Fix Ranges Compare Fix CompareRanges Nov 27, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Nov 27, 2024
nikvas0
nikvas0 commented Nov 27, 2024
View reviewed changes
Copy link
Collaborator Author

@nikvas0 nikvas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: looks like the problem is with CompareRanges, not CompareBorders.
I didn't notice "ranges lying on the left of compared borders".

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 13:12:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2ec56d9 has started.
⚪ 2024-11-27 13:13:18 UTC Artifacts will be uploaded here
⚪ 2024-11-27 13:17:07 UTC ya make is running...
🟡 2024-11-27 14:41:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32361 29465 0 2 2782 112

⚪ 2024-11-27 14:44:01 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-27 14:55:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
734 (only retried tests) 628 0 0 0 106

🟢 2024-11-27 14:55:47 UTC Build successful.
🟢 2024-11-27 14:56:06 UTC ydbd size 2.5 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e89b8d6 merge: 2ec56d9 diff diff %
ydbd size 2 694 386 536 Bytes 2 694 386 536 Bytes 0 Bytes 0.000%
ydbd stripped size 482 132 592 Bytes 482 132 592 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

⚪ 2024-11-27 13:14:27 UTC Pre-commit check linux-x86_64-release-asan for 2ec56d9 has started.
⚪ 2024-11-27 13:15:01 UTC Artifacts will be uploaded here
⚪ 2024-11-27 13:18:58 UTC ya make is running...
🟡 2024-11-27 15:00:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15019 14937 0 24 10 48

🟢 2024-11-27 15:01:13 UTC Build successful.
🟢 2024-11-27 15:01:42 UTC ydbd size 4.9 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e89b8d6 merge: 2ec56d9 diff diff %
ydbd size 5 293 665 816 Bytes 5 293 665 720 Bytes -96 Bytes -0.000%
ydbd stripped size 1 360 902 544 Bytes 1 360 902 480 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit 776b371 into ydb-platform:main Nov 28, 2024
10 checks passed
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
@naspirato naspirato mentioned this pull request Dec 1, 2024
Open
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Dec 4, 2024
@nikvas0
Fix CompareRanges (ydb-platform#12043)
9f6b09d
@nikvas0 nikvas0 mentioned this pull request Dec 4, 2024
Merged
@zverevgeny zverevgeny mentioned this pull request Jan 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@ssmike ssmike ssmike left review comments

@snaury snaury Awaiting requested review from snaury

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikvas0 @ssmike @gridnevvvit