-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage balancer info in hive ui & sensors KIKIMR-2190 #1200
Conversation
⚪
|
⚪
|
HIVE_CHANNEL_BALANCE_STRATEGY_HEAVIEST = 0; | ||
HIVE_CHANNEL_BALANCE_STRATEGY_RANDOM = 1; | ||
HIVE_CHANNEL_BALANCE_STRATEGY_WEIGHTED_RANDOM = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces compatibility issues with config versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, but this is the PR that adds the ability to use this enum through web ui. The enum is not in any of stable releases, and I don't believe anyone has a yaml-config with it anywhere at this point.
(I changed it because it turns out C++ proto enum descriptors assume that enum values are consecutive and start with zero)
ydb/core/protos/counters_hive.proto
Outdated
@@ -44,6 +45,7 @@ enum ECumulativeCounters { | |||
COUNTER_SUGGESTED_SCALE_UP = 10 [(CounterOpts) = {Name: "SuggestedScaleUp"}]; | |||
COUNTER_SUGGESTED_SCALE_DOWN = 11 [(CounterOpts) = {Name: "SuggestedScaleDown"}]; | |||
COUNTER_STORAGE_BALANCER_EXECUTED = 12 [(CounterOpts) = {Name: "StorageBalancerExecuted"}]; | |||
COUNTER_TABLETS_REASSIGNED = 13 [(CounterOpts) = {Name: "TabletsReassigned"}]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TabletsReassigned
quite possibly will be confused with TabletsMoved
.
May be there is a more accurate name for tablet-storage groups assignment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the word 'storage' to counter name.
⚪
|
⚪
|
⚪
|
⚪
|
Changelog entry
Added storage balancer releated metrics to sensors and Hive web ui
Changelog category
Additional information
...