Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chunks reorder on loading #11736

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

Copy link

github-actions bot commented Nov 19, 2024

2024-11-19 10:06:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 846d8ef has started.
2024-11-19 10:06:55 UTC Artifacts will be uploaded here
2024-11-19 10:07:38 UTC Check cancelled

Copy link

github-actions bot commented Nov 19, 2024

2024-11-19 10:07:02 UTC Pre-commit check linux-x86_64-release-asan for 846d8ef has started.
2024-11-19 10:07:13 UTC Artifacts will be uploaded here
2024-11-19 10:07:38 UTC Check cancelled

Copy link

github-actions bot commented Nov 19, 2024

2024-11-19 10:09:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 77d45e0 has started.
2024-11-19 10:09:42 UTC Artifacts will be uploaded here
2024-11-19 10:10:41 UTC Check cancelled

Copy link

github-actions bot commented Nov 19, 2024

2024-11-19 10:12:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 08c3130 has started.
2024-11-19 10:12:11 UTC Artifacts will be uploaded here
2024-11-19 10:13:47 UTC Check cancelled

Copy link

github-actions bot commented Nov 19, 2024

2024-11-19 10:12:12 UTC Pre-commit check linux-x86_64-release-asan for 08c3130 has started.
2024-11-19 10:12:23 UTC Artifacts will be uploaded here
2024-11-19 10:13:48 UTC Check cancelled

Copy link

github-actions bot commented Nov 19, 2024

2024-11-19 10:15:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0f01e34 has started.
2024-11-19 10:15:20 UTC Artifacts will be uploaded here
2024-11-19 10:18:16 UTC ya make is running...
🟡 2024-11-19 11:06:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15190 13669 0 1 1405 115

2024-11-19 11:07:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-19 11:19:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 9 0 0 0 107

🟢 2024-11-19 11:19:28 UTC Build successful.
🟢 2024-11-19 11:19:47 UTC ydbd size 2.5 GiB changed* by +84.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 481ccad merge: 0f01e34 diff diff %
ydbd size 2 685 547 360 Bytes 2 685 633 568 Bytes +84.2 KiB +0.003%
ydbd stripped size 481 239 632 Bytes 481 254 800 Bytes +14.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 19, 2024

2024-11-19 10:17:57 UTC Pre-commit check linux-x86_64-release-asan for 0f01e34 has started.
2024-11-19 10:18:09 UTC Artifacts will be uploaded here
2024-11-19 10:21:16 UTC ya make is running...
🟡 2024-11-19 11:29:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8959 8884 0 16 11 48

🟢 2024-11-19 11:30:35 UTC Build successful.
🟡 2024-11-19 11:31:04 UTC ydbd size 4.9 GiB changed* by +144.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 481ccad merge: 0f01e34 diff diff %
ydbd size 5 263 069 840 Bytes 5 263 218 208 Bytes +144.9 KiB +0.003%
ydbd stripped size 1 351 510 096 Bytes 1 351 562 000 Bytes +50.7 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review November 19, 2024 11:40
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner November 19, 2024 11:40
@ivanmorozov333 ivanmorozov333 merged commit 3d63b20 into ydb-platform:main Nov 19, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the reorder_chunks branch November 19, 2024 11:40
@zverevgeny zverevgeny linked an issue Nov 25, 2024 that may be closed by this pull request
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify in ColumnShards
2 participants