Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data accessor has to own portion info #11060

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement

@ivanmorozov333 ivanmorozov333 changed the title Split data portion info data accessor has to own portion info Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 13:39:57 UTC Pre-commit check linux-x86_64-release-asan for 47ed52f has started.
2024-10-29 13:40:07 UTC Artifacts will be uploaded here
2024-10-29 13:43:19 UTC ya make is running...
2024-10-29 13:59:34 UTC Check cancelled

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 13:40:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47ed52f has started.
2024-10-29 13:41:06 UTC Artifacts will be uploaded here
2024-10-29 13:44:06 UTC ya make is running...
2024-10-29 13:59:40 UTC Check cancelled

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 14:01:26 UTC Pre-commit check linux-x86_64-release-asan for 7482f2e has started.
2024-10-29 14:01:58 UTC Check cancelled

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 14:05:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5101afd has started.
2024-10-29 14:05:22 UTC Artifacts will be uploaded here
2024-10-29 14:05:54 UTC Check cancelled

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 14:05:24 UTC Pre-commit check linux-x86_64-release-asan for 5101afd has started.
2024-10-29 14:05:35 UTC Artifacts will be uploaded here
2024-10-29 14:05:55 UTC Check cancelled

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 14:08:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0131bf6 has started.
2024-10-29 14:08:16 UTC Artifacts will be uploaded here
2024-10-29 14:10:16 UTC Check cancelled

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 14:08:05 UTC Pre-commit check linux-x86_64-release-asan for 0131bf6 has started.
2024-10-29 14:08:16 UTC Artifacts will be uploaded here
2024-10-29 14:10:18 UTC Check cancelled

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 14:12:03 UTC Pre-commit check linux-x86_64-release-asan for b17275b has started.
2024-10-29 14:12:16 UTC Artifacts will be uploaded here
2024-10-29 14:15:16 UTC ya make is running...
🟡 2024-10-29 15:35:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9167 9108 0 21 7 31

🟢 2024-10-29 15:36:48 UTC Build successful.
🔴 2024-10-29 15:37:20 UTC ydbd size 5.7 GiB changed* by +4.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 06b8cb8 merge: b17275b diff diff %
ydbd size 6 142 267 184 Bytes 6 146 964 984 Bytes +4.5 MiB +0.076%
ydbd stripped size 1 532 866 544 Bytes 1 533 986 256 Bytes +1.1 MiB +0.073%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 29, 2024

2024-10-29 14:13:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for b17275b has started.
2024-10-29 14:13:48 UTC Artifacts will be uploaded here
2024-10-29 14:16:48 UTC ya make is running...
🟢 2024-10-29 15:10:56 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15044 13554 0 0 1394 96

🟢 2024-10-29 15:12:11 UTC Build successful.
🔴 2024-10-29 15:12:30 UTC ydbd size 2.8 GiB changed* by +3.6 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 103d800 merge: b17275b diff diff %
ydbd size 3 034 031 192 Bytes 3 037 757 200 Bytes +3.6 MiB +0.123%
ydbd stripped size 480 686 232 Bytes 481 184 120 Bytes +486.2 KiB +0.104%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review October 29, 2024 16:19
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner October 29, 2024 16:19
@ivanmorozov333 ivanmorozov333 enabled auto-merge (squash) October 29, 2024 16:19
@ivanmorozov333 ivanmorozov333 merged commit 08f5064 into ydb-platform:main Oct 29, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the split_data_portion_info branch October 29, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants