fix compilation of SerializeToBinaryJson on macos #10783
Conversation
swalrus1
commented
Oct 23, 2024
•
swalrus1
commented
- fix build
- add info to error messages
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
swalrus1
changed the title
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -22,6 +22,10 @@ SRCS( | |||
|
|
|||
| GENERATE_ENUM_SERIALIZATION(format.h) | |||
|
|
|||
| CFLAGS( | |||
There was a problem hiding this comment.
Игнорирование warning'а, чтобы сборка хедеров simdjson не падала на windows
There was a problem hiding this comment.
Правильно ли понял, что здесь это были варнинги внешней библиотеки simdjson?
There was a problem hiding this comment.
Да, вот они в логах сборки: https://nda.ya.ru/t/HW0alCdi79HxbP
| RETURN_IF_NOT_SUCCESS(value.get(v)); | ||
| callbacks.OnInteger(v); | ||
| break; | ||
| } | ||
| case simdjson::dom::element_type::UINT64: { | ||
| ui64 v; | ||
| uint64_t v; |
There was a problem hiding this comment.
ui64 -- unsigned long на windows, из-за чего компиляция value.get(v) падает
| RETURN_IF_NOT_SUCCESS(value.get(v)); | ||
| callbacks.OnInteger(v); | ||
| break; | ||
| } | ||
| case simdjson::fallback::number_type::unsigned_integer: { | ||
| ui64 v; | ||
| case simdjson::builtin::number_type::unsigned_integer: { |
There was a problem hiding this comment.
fallback -- конкретная имплементация парсера
builtin -- имплементация парсера, выбранная при компиляции
ydb/core/formats/arrow/converter.cpp
Outdated
| return arrow::Status::SerializationError( | ||
| "Cannot serialize json (", binaryJson.GetErrorMessage(), "): ", valueBuf.SubStr(0, Min(valueBuf.Size(), 1024ul))); | ||
| return arrow::Status::SerializationError("Cannot serialize json (", binaryJson.GetErrorMessage(), | ||
| "): ", valueBuf.SubStr(0, Min(valueBuf.Size(), static_cast<size_t>(1024)))); |
There was a problem hiding this comment.
Наверное в static_cast литерала ничего плохого нет, но я бы написал size_t{1024} здесь
| @@ -22,6 +22,10 @@ SRCS( | |||
|
|
|||
| GENERATE_ENUM_SERIALIZATION(format.h) | |||
|
|
|||
| CFLAGS( | |||
There was a problem hiding this comment.
Правильно ли понял, что здесь это были варнинги внешней библиотеки simdjson?
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
