[ldap] Prohibit requests with empty password #10401

molotkov-and · 2024-10-14T12:06:39Z

Changelog entry

...

Changelog category

Improvement

Additional information

...

github-actions · 2024-10-14T12:08:38Z

⚪ 2024-10-14 12:08:38 UTC Pre-commit check for a68a871 has started.
⚪ 2024-10-14 12:11:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-14 12:17:09 UTC Build successful.

github-actions · 2024-10-14T12:08:44Z

⚪ 2024-10-14 12:08:44 UTC Pre-commit check for a68a871 has started.
⚪ 2024-10-14 12:11:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-14 12:35:49 UTC Build successful.
⚪ 2024-10-14 12:36:08 UTC Tests are running...
🔴 2024-10-14 14:32:02 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10068	9991	0	9	25	43

🟢 2024-10-14 14:32:45 UTC ydbd size 5.5 GiB changed* by +9.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: `f6729a6`	merge: `a68a871`	diff	diff %
ydbd size	5 956 818 096 Bytes	5 956 827 744 Bytes	+9.4 KiB	+0.000%
ydbd stripped size	1 495 164 896 Bytes	1 495 166 304 Bytes	+1.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-14T12:11:26Z

⚪ 2024-10-14 12:11:25 UTC Pre-commit check for a68a871 has started.
⚪ 2024-10-14 12:13:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-14 12:50:56 UTC Build successful.
⚪ 2024-10-14 12:51:13 UTC Tests are running...
🔴 2024-10-14 14:12:22 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14367	13022	0	4	1299	42

🟢 2024-10-14 14:13:08 UTC ydbd size 8.2 GiB changed* by +8.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: `f6729a6`	merge: `a68a871`	diff	diff %
ydbd size	8 809 812 312 Bytes	8 809 821 304 Bytes	+8.8 KiB	+0.000%
ydbd stripped size	481 749 000 Bytes	481 749 512 Bytes	+512 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-14T14:49:26Z

⚪ 2024-10-14 14:49:25 UTC Pre-commit check for 0f69341 has started.
⚪ 2024-10-14 14:51:58 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-14 14:57:52 UTC Build successful.

github-actions · 2024-10-14T14:49:40Z

⚪ 2024-10-14 14:49:40 UTC Pre-commit check for 0f69341 has started.
⚪ 2024-10-14 14:52:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-14 15:31:28 UTC Build successful.
⚪ 2024-10-14 15:31:50 UTC Tests are running...
🔴 2024-10-14 16:55:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14368	13018	0	6	1300	44

🟢 2024-10-14 16:56:15 UTC ydbd size 8.2 GiB changed* by +8.9 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: `cda9edf`	merge: `0f69341`	diff	diff %
ydbd size	8 810 668 416 Bytes	8 810 677 552 Bytes	+8.9 KiB	+0.000%
ydbd stripped size	481 769 800 Bytes	481 770 376 Bytes	+576 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-14T14:49:40Z

⚪ 2024-10-14 14:49:40 UTC Pre-commit check for 0f69341 has started.
⚪ 2024-10-14 14:52:13 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-14 15:15:14 UTC Build successful.
⚪ 2024-10-14 15:15:32 UTC Tests are running...
🔴 2024-10-14 17:08:24 UTC Test run completed, no test results found for commit fafae3f. Please check test log.
🟢 2024-10-14 17:08:59 UTC ydbd size 5.5 GiB changed* by +9.5 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: `cda9edf`	merge: `0f69341`	diff	diff %
ydbd size	5 957 453 536 Bytes	5 957 463 216 Bytes	+9.5 KiB	+0.000%
ydbd stripped size	1 495 259 680 Bytes	1 495 261 088 Bytes	+1.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}
⚫ 2024-10-14 17:09:01 UTC Check cancelled

github-actions · 2024-10-14T17:10:41Z

⚪ 2024-10-14 17:10:40 UTC Pre-commit check for 826facc has started.
⚪ 2024-10-14 17:13:45 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-14 17:20:30 UTC Build successful.

github-actions · 2024-10-14T17:12:23Z

⚪ 2024-10-14 17:12:23 UTC Pre-commit check for 826facc has started.
⚪ 2024-10-14 17:15:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-14 17:37:14 UTC Build successful.
⚪ 2024-10-14 17:37:32 UTC Tests are running...
🔴 2024-10-14 19:39:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10074	9983	0	20	28	43

🟢 2024-10-14 19:40:20 UTC ydbd size 5.5 GiB changed* by +3.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: `9903295`	merge: `826facc`	diff	diff %
ydbd size	5 957 480 544 Bytes	5 957 484 000 Bytes	+3.4 KiB	+0.000%
ydbd stripped size	1 495 263 456 Bytes	1 495 264 032 Bytes	+576 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-14T17:12:24Z

⚪ 2024-10-14 17:12:23 UTC Pre-commit check for 826facc has started.
⚪ 2024-10-14 17:15:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-14 17:54:51 UTC Build successful.
⚪ 2024-10-14 17:55:10 UTC Tests are running...
🔴 2024-10-14 19:24:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14368	13020	0	6	1299	43

🟢 2024-10-14 19:25:58 UTC ydbd size 8.2 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash	stable-24-3: `9903295`	merge: `826facc`	diff	diff %
ydbd size	8 810 681 096 Bytes	8 810 683 912 Bytes	+2.8 KiB	+0.000%
ydbd stripped size	481 771 592 Bytes	481 771 848 Bytes	+256 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

molotkov-and requested a review from a team as a code owner October 14, 2024 12:06

molotkov-and requested a review from ijon October 14, 2024 12:06

fomichev3000 previously approved these changes Oct 14, 2024

View reviewed changes

molotkov-and dismissed fomichev3000’s stale review via fafae3f October 14, 2024 14:46

molotkov-and force-pushed the ldap/stable-24-3/restrict-empty-password branch from 8dcb493 to fafae3f Compare October 14, 2024 14:46

[ldap] Prohibit requests with empty password

67e0ca3

molotkov-and force-pushed the ldap/stable-24-3/restrict-empty-password branch from fafae3f to 67e0ca3 Compare October 14, 2024 17:08

molotkov-and requested a review from fomichev3000 October 15, 2024 06:40

fomichev3000 approved these changes Oct 15, 2024

View reviewed changes

molotkov-and merged commit 41ca9ba into ydb-platform:stable-24-3 Oct 15, 2024
8 of 12 checks passed

molotkov-and deleted the ldap/stable-24-3/restrict-empty-password branch October 15, 2024 08:32

zinal pushed a commit to zinal/ydb that referenced this pull request Oct 21, 2024

[ldap] Prohibit requests with empty password (ydb-platform#10401)

d99cd83

uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Oct 24, 2024

[ldap] Prohibit requests with empty password (ydb-platform#10401)

c143dd8

This was referenced Oct 29, 2024

viewer healthcheck pathmerge stable 24 3 11 hotfix #11042

Closed

viewer healthcheck pathmerge stable 24 #11044

Closed

zinal pushed a commit to zinal/ydb that referenced this pull request Nov 7, 2024

[ldap] Prohibit requests with empty password (ydb-platform#10401)

ee6c963

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ldap] Prohibit requests with empty password #10401

[ldap] Prohibit requests with empty password #10401

molotkov-and commented Oct 14, 2024

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

[ldap] Prohibit requests with empty password #10401

[ldap] Prohibit requests with empty password #10401

Conversation

molotkov-and commented Oct 14, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading