Force precompute for returning effect input #10231

ssmike · 2024-10-08T19:51:12Z

Changelog entry

Force precompute on returning effect input

Changelog category

Bugfix

github-actions · 2024-10-08T19:53:58Z

⚪ 2024-10-08 19:53:57 UTC Pre-commit check linux-x86_64-release-asan for 65f6824 has started.
⚪ 2024-10-08 19:54:11 UTC Artifacts will be uploaded here
⚪ 2024-10-08 19:57:04 UTC ya make is running...
🟡 2024-10-08 21:22:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10994	10753	0	68	70	103

🟢 2024-10-08 21:23:51 UTC Build successful.
🟢 2024-10-08 21:24:22 UTC ydbd size 5.7 GiB changed* by +912 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `6ba47a0`	merge: `65f6824`	diff	diff %
ydbd size	6 098 115 704 Bytes	6 098 116 616 Bytes	+912 Bytes	+0.000%
ydbd stripped size	1 520 340 720 Bytes	1 520 340 272 Bytes	-448 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-08T19:55:54Z

⚪ 2024-10-08 19:55:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 65f6824 has started.
⚪ 2024-10-08 19:56:04 UTC Artifacts will be uploaded here
⚪ 2024-10-08 19:58:59 UTC ya make is running...
🟡 2024-10-08 20:59:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73770	59819	0	2	13841	108

⚪ 2024-10-08 21:06:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-08 21:17:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
109 (only retried tests)	9	0	0	0	100

🟢 2024-10-08 21:17:47 UTC Build successful.
🟢 2024-10-08 21:18:07 UTC ydbd size 2.8 GiB changed* by -560 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `6ba47a0`	merge: `65f6824`	diff	diff %
ydbd size	3 008 763 544 Bytes	3 008 762 984 Bytes	-560 Bytes	-0.000%
ydbd stripped size	477 384 888 Bytes	477 384 568 Bytes	-320 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

rvu1024 · 2024-10-11T08:57:44Z

ydb/library/yql/dq/opt/dq_opt_phy.cpp

@@ -2733,6 +2733,16 @@ TExprBase DqPropagatePrecomuteTake(TExprBase node, TExprContext& ctx, IOptimizat
        return node;
    }

+    auto* typeAnn = precompute.Connection().Raw()->GetTypeAnn();
+    if (!typeAnn || typeAnn->GetKind() != ETypeAnnotationKind::Stream) {


typeAnn не может быть null в этом месте. Если это так, то это баг оптмизаторов и его надо чинить.

Коннекшены типизируюся как List. Почему этот код должен работать?

Переделал на List и сделал проверку более специфичной чтобы покрыть наш конкретный кейс

rvu1024 · 2024-10-11T08:58:34Z

ydb/library/yql/dq/opt/dq_opt_phy.cpp

+        return node;
+    }
+
+    typeAnn = typeAnn->Cast<TStreamExprType>()->GetItemType();


GetSeqItemType()

ydb/library/yql/dq/opt/dq_opt_phy.cpp

rvu1024

см. выше

github-actions · 2024-10-21T08:36:54Z

⚪ 2024-10-21 08:36:53 UTC Pre-commit check linux-x86_64-release-asan for d7a1927 has started.
⚪ 2024-10-21 08:37:05 UTC Artifacts will be uploaded here
⚪ 2024-10-21 08:40:14 UTC ya make is running...
🟡 2024-10-21 10:06:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10963	10675	0	86	98	104

🟢 2024-10-21 10:07:40 UTC Build successful.
🟢 2024-10-21 10:08:12 UTC ydbd size 5.7 GiB changed* by +8.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `3fb6997`	merge: `d7a1927`	diff	diff %
ydbd size	6 108 606 952 Bytes	6 108 616 008 Bytes	+8.8 KiB	+0.000%
ydbd stripped size	1 522 673 392 Bytes	1 522 674 928 Bytes	+1.5 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T08:40:50Z

⚪ 2024-10-21 08:40:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for d7a1927 has started.
⚪ 2024-10-21 08:41:01 UTC Artifacts will be uploaded here
⚪ 2024-10-21 08:44:08 UTC ya make is running...
🟡 2024-10-21 09:44:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73923	59918	0	3	13905	97

⚪ 2024-10-21 09:50:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-21 10:02:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
100 (only retried tests)	7	0	0	0	93

🟢 2024-10-21 10:02:15 UTC Build successful.
🟢 2024-10-21 10:02:36 UTC ydbd size 2.8 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `3fb6997`	merge: `d7a1927`	diff	diff %
ydbd size	3 015 212 080 Bytes	3 015 213 856 Bytes	+1.7 KiB	+0.000%
ydbd stripped size	477 965 208 Bytes	477 965 528 Bytes	+320 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T10:41:15Z

⚪ 2024-10-21 10:41:14 UTC Pre-commit check linux-x86_64-release-asan for e0670af has started.
⚪ 2024-10-21 10:41:48 UTC Artifacts will be uploaded here
⚪ 2024-10-21 10:45:26 UTC ya make is running...
🟡 2024-10-21 12:09:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10955	10706	0	75	64	110

🟢 2024-10-21 12:10:04 UTC Build successful.
🟢 2024-10-21 12:10:45 UTC ydbd size 5.7 GiB changed* by +5.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `7f4d37b`	merge: `e0670af`	diff	diff %
ydbd size	6 108 702 688 Bytes	6 108 708 728 Bytes	+5.9 KiB	+0.000%
ydbd stripped size	1 522 711 760 Bytes	1 522 713 296 Bytes	+1.5 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T10:42:47Z

⚪ 2024-10-21 10:42:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for e0670af has started.
⚪ 2024-10-21 10:42:57 UTC Artifacts will be uploaded here
⚪ 2024-10-21 10:46:01 UTC ya make is running...
🟡 2024-10-21 11:47:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73923	59919	0	4	13904	96

⚪ 2024-10-21 11:55:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-21 12:06:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
100 (only retried tests)	5	0	1	1	93

⚪ 2024-10-21 12:07:02 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-21 12:18:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
94 (only retried tests)	2	0	0	0	92

🟢 2024-10-21 12:18:52 UTC Build successful.
🟢 2024-10-21 12:19:14 UTC ydbd size 2.8 GiB changed* by +1.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `7f4d37b`	merge: `e0670af`	diff	diff %
ydbd size	3 015 313 344 Bytes	3 015 314 384 Bytes	+1.0 KiB	+0.000%
ydbd stripped size	477 978 264 Bytes	477 978 584 Bytes	+320 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T12:27:50Z

⚪ 2024-10-21 12:27:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7d8242d has started.
⚪ 2024-10-21 12:28:01 UTC Artifacts will be uploaded here
⚪ 2024-10-21 12:31:09 UTC ya make is running...
⚫ 2024-10-21 13:24:53 UTC Check cancelled

github-actions · 2024-10-21T12:29:07Z

⚪ 2024-10-21 12:29:07 UTC Pre-commit check linux-x86_64-release-asan for 7d8242d has started.
⚪ 2024-10-21 12:29:17 UTC Artifacts will be uploaded here
⚪ 2024-10-21 12:32:24 UTC ya make is running...
⚫ 2024-10-21 13:24:56 UTC Check cancelled

github-actions · 2024-10-21T13:27:02Z

⚪ 2024-10-21 13:27:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6612596 has started.
⚪ 2024-10-21 13:27:47 UTC Artifacts will be uploaded here
⚪ 2024-10-21 13:31:30 UTC ya make is running...
🟡 2024-10-21 14:31:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73923	59918	0	1	13905	99

⚪ 2024-10-21 14:38:37 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-21 14:49:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
100 (only retried tests)	9	0	0	0	91

🟢 2024-10-21 14:50:05 UTC Build successful.
🟢 2024-10-21 14:50:25 UTC ydbd size 2.8 GiB changed* by +1.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `96d03d6`	merge: `6612596`	diff	diff %
ydbd size	3 015 313 936 Bytes	3 015 315 376 Bytes	+1.4 KiB	+0.000%
ydbd stripped size	477 978 328 Bytes	477 978 648 Bytes	+320 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-21T13:29:29Z

⚪ 2024-10-21 13:29:29 UTC Pre-commit check linux-x86_64-release-asan for 6612596 has started.
⚪ 2024-10-21 13:29:39 UTC Artifacts will be uploaded here
⚪ 2024-10-21 13:32:42 UTC ya make is running...
🟡 2024-10-21 15:11:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10969	10629	0	107	120	113

🟢 2024-10-21 15:12:07 UTC Build successful.
🟢 2024-10-21 15:12:48 UTC ydbd size 5.7 GiB changed* by +7.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `e6f71f0`	merge: `6612596`	diff	diff %
ydbd size	6 108 702 688 Bytes	6 108 710 808 Bytes	+7.9 KiB	+0.000%
ydbd stripped size	1 522 711 760 Bytes	1 522 713 552 Bytes	+1.8 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Force precompute for returning effect input

6e0d92e

ssmike requested review from a team as code owners October 8, 2024 19:51

github-actions bot added the bugfix label Oct 8, 2024

gridnevvvit previously approved these changes Oct 10, 2024

View reviewed changes

rvu1024 reviewed Oct 11, 2024

View reviewed changes

rvu1024 requested changes Oct 14, 2024

View reviewed changes

make guard more specific

a83c9d6

ssmike dismissed gridnevvvit’s stale review via a83c9d6 October 21, 2024 08:33

use helper

d91d0e9

list/flow/stream

117ee55

ssmike force-pushed the force-precompute branch from e1dc002 to 117ee55 Compare October 21, 2024 13:24

rvu1024 approved these changes Oct 21, 2024

View reviewed changes

ssmike merged commit b91414f into ydb-platform:main Oct 22, 2024
10 checks passed

ssmike deleted the force-precompute branch October 22, 2024 05:29

ssmike mentioned this pull request Oct 22, 2024

Duplicate KqpCnSequencer in UPSERT/REPLACE plan #10179

Closed

ssmike added a commit to ssmike/ydb that referenced this pull request Oct 22, 2024

Force precompute for returning effect input (ydb-platform#10231)

5d48b01

GrigoriyPA mentioned this pull request Oct 23, 2024

YQ-3784 support computation graph invalidation in purecalc #10799

Merged

shnikd mentioned this pull request Nov 7, 2024

Support CollectDiagnostics in DATA_QUERY/GENERIC_QUERY #11371

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Force precompute for returning effect input #10231

Force precompute for returning effect input #10231

ssmike commented Oct 8, 2024

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

rvu1024 Oct 11, 2024

ssmike Oct 21, 2024

rvu1024 Oct 11, 2024

rvu1024 left a comment

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

Force precompute for returning effect input #10231

Force precompute for returning effect input #10231

Conversation

ssmike commented Oct 8, 2024

Changelog entry

Changelog category

github-actions bot commented Oct 8, 2024 • edited Loading

github-actions bot commented Oct 8, 2024 • edited Loading

rvu1024 Oct 11, 2024

Choose a reason for hiding this comment

ssmike Oct 21, 2024

Choose a reason for hiding this comment

rvu1024 Oct 11, 2024

Choose a reason for hiding this comment

rvu1024 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 21, 2024 • edited Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading