Added debug logging for table stats #10065

aavdonkin · 2024-10-03T16:39:15Z

Changelog entry

...

Additional information

...

github-actions · 2024-10-03T16:42:48Z

⚪ 2024-10-03 16:42:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5f80545 has started.
⚪ 2024-10-03 16:42:54 UTC Artifacts will be uploaded here
⚪ 2024-10-03 16:45:53 UTC ya make is running...
🟡 2024-10-03 17:33:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15250	13764	0	9	1377	100

⚪ 2024-10-03 17:34:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-03 17:46:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
105 (only retried tests)	5	0	6	0	94

⚪ 2024-10-03 17:46:09 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-03 17:57:32 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
100 (only retried tests)	3	0	6	0	91

🟢 2024-10-03 17:57:39 UTC Build successful.
🟢 2024-10-03 17:57:59 UTC ydbd size 2.8 GiB changed* by +19.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d4f2a48`	merge: `5f80545`	diff	diff %
ydbd size	3 001 749 816 Bytes	3 001 769 824 Bytes	+19.5 KiB	+0.001%
ydbd stripped size	477 341 368 Bytes	477 343 928 Bytes	+2.5 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-03T16:43:09Z

⚪ 2024-10-03 16:43:09 UTC Pre-commit check linux-x86_64-release-asan for 5f80545 has started.
⚪ 2024-10-03 16:43:22 UTC Artifacts will be uploaded here
⚪ 2024-10-03 16:46:22 UTC ya make is running...
🟡 2024-10-03 18:20:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10328	10033	0	114	77	104

🟢 2024-10-03 18:21:20 UTC Build successful.
🟢 2024-10-03 18:21:53 UTC ydbd size 5.7 GiB changed* by +53.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `95f3a50`	merge: `5f80545`	diff	diff %
ydbd size	6 086 062 176 Bytes	6 086 116 424 Bytes	+53.0 KiB	+0.001%
ydbd stripped size	1 520 523 536 Bytes	1 520 538 576 Bytes	+14.7 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-03T20:25:08Z

⚪ 2024-10-03 20:25:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for d0c868f has started.
⚪ 2024-10-03 20:25:29 UTC Artifacts will be uploaded here
⚪ 2024-10-03 20:28:25 UTC ya make is running...
🟢 2024-10-03 21:15:36 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15248	13774	0	0	1377	97

🟢 2024-10-03 21:16:47 UTC Build successful.
🟢 2024-10-03 21:17:04 UTC ydbd size 2.8 GiB changed* by +14.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `595af5f`	merge: `d0c868f`	diff	diff %
ydbd size	3 001 837 456 Bytes	3 001 851 808 Bytes	+14.0 KiB	+0.000%
ydbd stripped size	477 361 080 Bytes	477 362 552 Bytes	+1.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-03T20:25:44Z

⚪ 2024-10-03 20:25:43 UTC Pre-commit check linux-x86_64-release-asan for d0c868f has started.
⚪ 2024-10-03 20:26:40 UTC Artifacts will be uploaded here
⚪ 2024-10-03 20:30:05 UTC ya make is running...
🟡 2024-10-03 21:56:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10303	10058	0	77	63	105

🟢 2024-10-03 21:57:10 UTC Build successful.
🟢 2024-10-03 21:57:42 UTC ydbd size 5.7 GiB changed* by +44.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `595af5f`	merge: `d0c868f`	diff	diff %
ydbd size	6 086 289 376 Bytes	6 086 335 328 Bytes	+44.9 KiB	+0.001%
ydbd stripped size	1 520 590 960 Bytes	1 520 597 808 Bytes	+6.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/core/tx/columnshard/engines/column_engine_logs.cpp

github-actions · 2024-10-04T09:35:50Z

⚪ 2024-10-04 09:35:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for e1ae5b4 has started.
⚪ 2024-10-04 09:36:00 UTC Artifacts will be uploaded here
⚪ 2024-10-04 09:38:52 UTC ya make is running...
🟡 2024-10-04 10:24:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15270	13793	0	1	1377	99

⚪ 2024-10-04 10:26:14 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-04 10:37:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
98 (only retried tests)	7	0	0	0	91

🟢 2024-10-04 10:37:43 UTC Build successful.
🟢 2024-10-04 10:38:01 UTC ydbd size 2.8 GiB changed* by +16.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `b83b572`	merge: `e1ae5b4`	diff	diff %
ydbd size	3 001 164 784 Bytes	3 001 181 736 Bytes	+16.6 KiB	+0.001%
ydbd stripped size	477 259 768 Bytes	477 261 624 Bytes	+1.8 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-04T09:35:55Z

⚪ 2024-10-04 09:35:54 UTC Pre-commit check linux-x86_64-release-asan for e1ae5b4 has started.
⚪ 2024-10-04 09:36:05 UTC Artifacts will be uploaded here
⚪ 2024-10-04 09:38:55 UTC ya make is running...
🟡 2024-10-04 11:00:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10327	10099	0	65	55	108

🟢 2024-10-04 11:01:54 UTC Build successful.
🟢 2024-10-04 11:02:27 UTC ydbd size 5.7 GiB changed* by +55.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `3ed2931`	merge: `e1ae5b4`	diff	diff %
ydbd size	6 082 038 568 Bytes	6 082 095 000 Bytes	+55.1 KiB	+0.001%
ydbd stripped size	1 519 792 240 Bytes	1 519 801 584 Bytes	+9.1 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/core/tx/columnshard/engines/column_engine_logs.h

ydb/core/tx/schemeshard/schemeshard__table_stats.cpp

ydb/core/tx/columnshard/engines/column_engine_logs.cpp

github-actions · 2024-10-04T12:49:19Z

⚪ 2024-10-04 12:49:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 43057f8 has started.
⚪ 2024-10-04 12:49:22 UTC Artifacts will be uploaded here
⚪ 2024-10-04 12:52:23 UTC ya make is running...
⚫ 2024-10-04 13:28:02 UTC Check cancelled

github-actions · 2024-10-04T12:49:29Z

⚪ 2024-10-04 12:49:29 UTC Pre-commit check linux-x86_64-release-asan for 43057f8 has started.
⚪ 2024-10-04 12:49:33 UTC Artifacts will be uploaded here
⚪ 2024-10-04 12:52:23 UTC ya make is running...
⚫ 2024-10-04 13:27:58 UTC Check cancelled

ydb/core/tx/columnshard/engines/column_engine_logs.cpp

github-actions · 2024-10-04T13:29:40Z

⚪ 2024-10-04 13:29:40 UTC Pre-commit check linux-x86_64-release-asan for 143c9da has started.
⚪ 2024-10-04 13:29:51 UTC Artifacts will be uploaded here
⚪ 2024-10-04 13:32:52 UTC ya make is running...
🟡 2024-10-04 15:11:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10324	10096	0	63	56	109

🟢 2024-10-04 15:12:45 UTC Build successful.
🟡 2024-10-04 15:13:17 UTC ydbd size 5.7 GiB changed* by +253.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `2c63185`	merge: `143c9da`	diff	diff %
ydbd size	6 083 953 552 Bytes	6 084 212 680 Bytes	+253.1 KiB	+0.004%
ydbd stripped size	1 520 222 064 Bytes	1 520 269 040 Bytes	+45.9 KiB	+0.003%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-04T13:31:17Z

⚪ 2024-10-04 13:31:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 143c9da has started.
⚪ 2024-10-04 13:31:21 UTC Artifacts will be uploaded here
⚪ 2024-10-04 13:34:15 UTC ya make is running...
🟡 2024-10-04 14:21:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15269	13789	0	1	1378	101

⚪ 2024-10-04 14:23:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-04 14:35:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
102 (only retried tests)	8	0	0	1	93

🟢 2024-10-04 14:35:07 UTC Build successful.
🟡 2024-10-04 14:35:26 UTC ydbd size 2.8 GiB changed* by +808.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `da5623c`	merge: `143c9da`	diff	diff %
ydbd size	3 001 319 736 Bytes	3 002 147 856 Bytes	+808.7 KiB	+0.028%
ydbd stripped size	477 279 224 Bytes	477 363 384 Bytes	+82.2 KiB	+0.018%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Added debug logging for table stats

cccad41

aavdonkin requested a review from a team as a code owner October 3, 2024 16:39

github-actions bot added the new-feature label Oct 3, 2024

Fixed tests

7ee6907

ivanmorozov333 requested changes Oct 4, 2024

View reviewed changes

ydb/core/tx/columnshard/engines/column_engine_logs.cpp Outdated Show resolved Hide resolved

ydb/core/tx/columnshard/engines/column_engine_logs.cpp Outdated Show resolved Hide resolved

ivanmorozov333 requested changes Oct 4, 2024

View reviewed changes

ydb/core/tx/columnshard/engines/column_engine_logs.cpp Outdated Show resolved Hide resolved

ydb/core/tx/columnshard/engines/column_engine_logs.cpp Outdated Show resolved Hide resolved

Replace log macros to AFL_DEBUG

f5dc7bc

ivanmorozov333 requested changes Oct 4, 2024

View reviewed changes

ydb/core/tx/columnshard/engines/column_engine_logs.h Outdated Show resolved Hide resolved

ydb/core/tx/schemeshard/schemeshard__table_stats.cpp Show resolved Hide resolved

ydb/core/tx/columnshard/engines/column_engine_logs.cpp Outdated Show resolved Hide resolved

Use enum serialization

9a0ddf7

ivanmorozov333 requested changes Oct 4, 2024

View reviewed changes

ydb/core/tx/columnshard/engines/column_engine_logs.cpp Outdated Show resolved Hide resolved

Do not copy objects if logging is disabled with current settings

199418e

ivanmorozov333 approved these changes Oct 7, 2024

View reviewed changes

aavdonkin merged commit bff272f into ydb-platform:main Oct 7, 2024
10 checks passed

GrigoriyPA mentioned this pull request Oct 8, 2024

YQ-3722 add simdjson parser into RD #10204

Merged

aavdonkin linked an issue Oct 8, 2024 that may be closed by this pull request

Wrong used space immediately after alter object query #10213

Open

This was referenced Oct 21, 2024

Fix kafka cdc read and login without @ #10678

Merged

Allow short auto partitioning strategies yql #10701

Merged

zverevgeny mentioned this pull request Jan 9, 2025

Integrate changes from main #13202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added debug logging for table stats #10065

Added debug logging for table stats #10065

aavdonkin commented Oct 3, 2024

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

Added debug logging for table stats #10065

Added debug logging for table stats #10065

Conversation

aavdonkin commented Oct 3, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Oct 3, 2024 • edited Loading

github-actions bot commented Oct 3, 2024 • edited Loading

github-actions bot commented Oct 3, 2024 • edited Loading

github-actions bot commented Oct 3, 2024 • edited Loading

github-actions bot commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 4, 2024 • edited Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading