Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] QueryClient's session pool does not clean broken sessions #10284

Open
alex268 opened this issue Oct 10, 2024 · 0 comments
Open

[SDK] QueryClient's session pool does not clean broken sessions #10284

alex268 opened this issue Oct 10, 2024 · 0 comments
Assignees
@dcherednik
Labels
bug Something isn't working

Comments

@alex268
Copy link
Member

alex268 commented Oct 10, 2024

Base implementation contains a special interceptor for detecting of broken sessions. But this interceptor is not usable for a QueryService's session, which always creates stream iterators successfully. And errors raise on the iterator reads.
As result, if the session has been broken by any reason, the pool continues to use this session. In the end we can get the pool filled with broken sessions and nothing is working
@alex268 alex268 added the bug Something isn't working label Oct 10, 2024
dcherednik added a commit to dcherednik/ydb that referenced this issue Oct 15, 2024
@dcherednik
Remove session from pool in case of BAD_SESSION...
de256ca 
and other errors which should trigger removing session from pool.

Implemented by set SessionStatusInterceptor for stream iterator.

ydb-platform#10284
@dcherednik dcherednik mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcherednik dcherednik

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcherednik @alex268