Revert "Fix hash spreading in HashPartitionConsumer (#4364)" (#8753)

ydb-platform · Sep 5, 2024 · fe3a015 · fe3a015
1 parent 446ea4d
commit fe3a015
Showing 1 changed file with 0 additions and 15 deletions.
diff --git a/ydb/library/yql/dq/runtime/dq_output_consumer.cpp b/ydb/library/yql/dq/runtime/dq_output_consumer.cpp
@@ -21,11 +21,6 @@ using namespace NKikimr;
 using namespace NMiniKQL;
 using namespace NUdf;
 
-inline ui64 SpreadHash(ui64 hash) {
-    // https://probablydance.com/2018/06/16/fibonacci-hashing-the-optimization-that-the-world-forgot-or-a-better-alternative-to-integer-modulo/
-    return ((unsigned __int128)hash * 11400714819323198485llu) >> 64;
-}
-
 
 class TDqOutputMultiConsumer : public IDqOutputConsumer {
 public:
@@ -195,9 +190,6 @@ class TDqOutputHashPartitionConsumer : public IDqOutputConsumer {
             hash = CombineHashes(hash, HashColumn(keyId, columnValue));
         }
 
-
-        hash = SpreadHash(hash);
-
         return hash % Outputs.size();
     }
 
@@ -209,8 +201,6 @@ class TDqOutputHashPartitionConsumer : public IDqOutputConsumer {
             hash = CombineHashes(hash, HashColumn(keyId, values[KeyColumns[keyId].Index]));
         }
 
-        hash = SpreadHash(hash);
-
         return hash % Outputs.size();
     }
 
@@ -314,8 +304,6 @@ class TDqOutputHashPartitionConsumerScalar : public IDqOutputConsumer {
             hash = CombineHashes(hash, HashColumn(keyId, values[KeyColumns_[keyId].Index]));
         }
 
-        hash = SpreadHash(hash);
-
         return hash % Outputs_.size();
     }
 
@@ -513,9 +501,6 @@ class TDqOutputHashPartitionConsumerBlock : public IDqOutputConsumer {
             }
             hash = CombineHashes(hash, keyHash);
         }
-
-        hash = SpreadHash(hash);
-
         return hash % Outputs_.size();
     }