Fixed issues

ydb-platform · Sep 6, 2024 · fe06452 · fe06452
1 parent 14fd621
commit fe06452
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/ydb/services/metadata/manager/alter_impl.h b/ydb/services/metadata/manager/alter_impl.h
@@ -138,7 +138,7 @@ class TModificationActorImpl: public NActors::TActorBootstrapped<TModificationAc
     void Handle(TEvFetchDatabaseResponse::TPtr& ev) {
         TString errorMessage;
         if (const auto& errorString = ev->Get()->GetErrorString()) {
-            errorMessage = TStringBuilder() << "Cannot fetch database '" << Context.GetExternalData().GetDatabase() << "': " << errorString;
+            errorMessage = TStringBuilder() << "Cannot fetch database '" << Context.GetExternalData().GetDatabase() << "': " << *errorString;
         } else if (ev->Get()->GetServerless()) {
             errorMessage = TStringBuilder() << "Objects " << TObject::GetTypeId() << " are disabled for serverless domains. Please contact your system administrator to enable it";
         }

diff --git a/ydb/services/metadata/manager/fetch_database.cpp b/ydb/services/metadata/manager/fetch_database.cpp
@@ -91,7 +91,7 @@ class TDatabaseFetcherActor : public TActorBootstrapped<TDatabaseFetcherActor> {
         return false;
     }
 
-    void Reply(const TString& errorMessage = "") {
+    void Reply(const std::optional<TString>& errorMessage = std::nullopt) {
         Send(Owner, new TEvFetchDatabaseResponse(Serverless, errorMessage));
         PassAway();
     }

diff --git a/ydb/services/metadata/manager/fetch_database.h b/ydb/services/metadata/manager/fetch_database.h
@@ -10,10 +10,10 @@ namespace NKikimr::NMetadata::NModifications {
 class TEvFetchDatabaseResponse : public TEventLocal<TEvFetchDatabaseResponse, EvFetchDatabaseResponse> {
 private:
     YDB_READONLY_DEF(bool, Serverless);
-    YDB_READONLY_DEF(TString, ErrorString);
+    YDB_READONLY_DEF(std::optional<TString>, ErrorString);
 
 public:
-    TEvFetchDatabaseResponse(bool serverless, const TString& errorString)
+    TEvFetchDatabaseResponse(bool serverless, const std::optional<TString>& errorString)
         : Serverless(serverless)
         , ErrorString(errorString)
     {}