Skip to content

Commit

Permalink
get rid of mkql results in scripting (#9997)
Browse files Browse the repository at this point in the history
  • Loading branch information
gridnevvvit committed Oct 7, 2024
1 parent 24eb06b commit e33cb20
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 15 deletions.
7 changes: 0 additions & 7 deletions ydb/core/kqp/common/kqp_event_impl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,7 @@ void TEvKqp::TEvQueryRequest::PrepareRemote() const {
Record.MutableRequest()->SetPoolId(PoolId);
}

<<<<<<< HEAD
=======
if (!DatabaseId.empty()) {
Record.MutableRequest()->SetDatabaseId(DatabaseId);
}

Record.MutableRequest()->SetUsePublicResponseDataFormat(true);
>>>>>>> a491b73df3 (get rid of mkql results in scripting (#9997))
Record.MutableRequest()->SetSessionId(SessionId);
Record.MutableRequest()->SetAction(QueryAction);
Record.MutableRequest()->SetType(QueryType);
Expand Down
1 change: 0 additions & 1 deletion ydb/core/kqp/provider/yql_kikimr_gateway.h
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,6 @@ class IKikimrGateway : public TThrRefBase {
TString SessionId;
TVector<Ydb::ResultSet*> Results;
TMaybe<NKikimrKqp::TQueryProfile> Profile; // TODO: Deprecate.
a491b73df3 (get rid of mkql results in scripting (#9997))
NKqpProto::TKqpStatsQuery QueryStats;
std::unique_ptr<NKikimrKqp::TPreparedQuery> PreparingQuery;
std::shared_ptr<const NKikimrKqp::TPreparedQuery> PreparedQuery;
Expand Down
8 changes: 1 addition & 7 deletions ydb/core/viewer/viewer_query.h
Original file line number Diff line number Diff line change
Expand Up @@ -546,14 +546,8 @@ class TJsonQuery : public TViewerPipeClient {
void MakeOkReply(NJson::TJsonValue& jsonResponse, NKikimrKqp::TEvQueryResponse& record) {
const auto& response = record.GetResponse();

if (response.YdbResultsSize() > 0 || response.ResultsSize() > 0) {
if (response.YdbResultsSize() > 0) {
try {
for (const auto& result : response.GetResults()) {
Ydb::ResultSet resultSet;
NKqp::ConvertKqpQueryResultToDbResult(result, &resultSet);
ResultSets.emplace_back().emplace_back(std::move(resultSet));
}

for (const auto& result : response.GetYdbResults()) {
ResultSets.emplace_back().emplace_back(result);
}
Expand Down

0 comments on commit e33cb20

Please sign in to comment.