Skip to content

Commit

Permalink
Merge 423a6f9 into 1ceb8e0
Browse files Browse the repository at this point in the history
  • Loading branch information
dcherednik authored Aug 16, 2024
2 parents 1ceb8e0 + 423a6f9 commit d3cf782
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
6 changes: 2 additions & 4 deletions ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1945,8 +1945,7 @@ Y_UNIT_TEST_SUITE(KqpScheme) {
}

Y_UNIT_TEST(CreateTableWithPartitionAtKeysUuid) {
TKikimrSettings kikimrSettings = TKikimrSettings()
.SetEnableUuidAsPrimaryKey(true);
TKikimrSettings kikimrSettings;
TKikimrRunner kikimr(kikimrSettings);
auto db = kikimr.GetTableClient();
auto session = db.CreateSession().GetValueSync().GetSession();
Expand Down Expand Up @@ -1990,8 +1989,7 @@ Y_UNIT_TEST_SUITE(KqpScheme) {
}

Y_UNIT_TEST(CreateTableWithUniformPartitionsUuid) {
TKikimrSettings kikimrSettings = TKikimrSettings()
.SetEnableUuidAsPrimaryKey(true);
TKikimrSettings kikimrSettings;
TKikimrRunner kikimr(kikimrSettings);
auto db = kikimr.GetTableClient();
auto session = db.CreateSession().GetValueSync().GetSession();
Expand Down
5 changes: 1 addition & 4 deletions ydb/core/kqp/ut/yql/kqp_yql_ut.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,7 @@ Y_UNIT_TEST_SUITE(KqpYql) {
appConfig.MutableTableServiceConfig()->SetEnablePreparedDdl(true);
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
.SetEnableUuidAsPrimaryKey(false)
.SetAppConfig(appConfig)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings.SetWithSampleTables(false));
Expand Down Expand Up @@ -684,7 +685,6 @@ Y_UNIT_TEST_SUITE(KqpYql) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
.SetAppConfig(appConfig)
.SetEnableUuidAsPrimaryKey(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings.SetWithSampleTables(false));

Expand Down Expand Up @@ -833,7 +833,6 @@ Y_UNIT_TEST_SUITE(KqpYql) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
.SetAppConfig(appConfig)
.SetEnableUuidAsPrimaryKey(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings.SetWithSampleTables(false));

Expand Down Expand Up @@ -890,7 +889,6 @@ Y_UNIT_TEST_SUITE(KqpYql) {
auto setting = NKikimrKqp::TKqpSetting();
auto serverSettings = TKikimrSettings()
.SetAppConfig(appConfig)
.SetEnableUuidAsPrimaryKey(true)
.SetKqpSettings({setting});
TKikimrRunner kikimr(serverSettings.SetWithSampleTables(false));

Expand All @@ -917,7 +915,6 @@ Y_UNIT_TEST_SUITE(KqpYql) {

Y_UNIT_TEST(UuidPrimaryKeyBulkUpsert) {
auto settings = TKikimrSettings()
.SetEnableUuidAsPrimaryKey(true)
.SetWithSampleTables(false);
auto kikimr = TKikimrRunner{settings};
auto db = kikimr.GetTableClient();
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/protos/feature_flags.proto
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ message TFeatureFlags {
optional bool EnableUniqConstraint = 104 [default = false];
optional bool EnableChangefeedDebeziumJsonFormat = 105 [default = false];
optional bool EnableStatistics = 106 [default = true];
optional bool EnableUuidAsPrimaryKey = 107 [default = false];
optional bool EnableUuidAsPrimaryKey = 107 [default = true];
optional bool EnableTablePgTypes = 108 [default = false];
optional bool EnableLocalDBBtreeIndex = 109 [default = true];
optional bool EnablePDiskHighHDDInFlight = 110 [default = false];
Expand Down

0 comments on commit d3cf782

Please sign in to comment.