Skip to content

Commit

Permalink
Fix GetColumnSerializationStats and ResourceSubscriber task name (#1618)
Browse files Browse the repository at this point in the history
  • Loading branch information
nsofya authored Feb 6, 2024
1 parent 24789bc commit a35afbc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ydb/core/tx/columnshard/normalizer/abstract/abstract.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ namespace NKikimr::NOlap {
public:
TNormalizationController(std::shared_ptr<IStoragesManager> storagesManager, const std::shared_ptr<NOlap::NResourceBroker::NSubscribe::TSubscriberCounters>& counters)
: StoragesManager(storagesManager)
, TaskSubscription("CS:NORMALIZER", counters) {}
, TaskSubscription("CS::NORMALIZER", counters) {}

const NOlap::NResourceBroker::NSubscribe::TTaskContext& GetTaskSubscription() const {
return TaskSubscription;
Expand Down
6 changes: 5 additions & 1 deletion ydb/core/tx/columnshard/splitter/batch_slice.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ class TDefaultSchemaDetails: public ISchemaDetailInfo {
}

virtual std::optional<TColumnSerializationStat> GetColumnSerializationStats(const ui32 columnId) const override {
return Stats->GetColumnInfo(columnId);
auto stats = Stats->GetColumnInfo(columnId);
if (stats && stats->GetRecordsCount() != 0) {
return stats;
}
return std::nullopt;
}
virtual std::optional<TBatchSerializationStat> GetBatchSerializationStats(const std::shared_ptr<arrow::RecordBatch>& rb) const override {
return Stats->GetStatsForRecordBatch(rb);
Expand Down

0 comments on commit a35afbc

Please sign in to comment.