Skip to content

Commit

Permalink
Reorder hints for simple Arrow UDF with optionals
Browse files Browse the repository at this point in the history
To ensure everything works fine as a result of the previous patch, the
hints used to create simple Arrow UDFs with optional arguments are
reordered in the right way.
  • Loading branch information
igormunkin committed May 13, 2024
1 parent 695f15d commit a2b08e0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ydb/library/yql/public/udf/arrow/udf_arrow_helpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -623,11 +623,11 @@ class TUnaryOverOptionalImpl : public TBoxedValue {

#define BEGIN_SIMPLE_ARROW_UDF_WITH_OPTIONAL_ARGS(udfName, signatureFunc, optArgc) \
BEGIN_ARROW_UDF_IMPL(udfName##_BlocksImpl, signatureFunc, optArgc, false) \
UDF_IMPL(udfName, builder.SimpleSignature<signatureFunc>().OptionalArgs(optArgc).SupportsBlocks();, ;, ;, "", "", udfName##_BlocksImpl)
UDF_IMPL(udfName, builder.SimpleSignature<signatureFunc>().SupportsBlocks().OptionalArgs(optArgc);, ;, ;, "", "", udfName##_BlocksImpl)

#define BEGIN_SIMPLE_STRICT_ARROW_UDF_WITH_OPTIONAL_ARGS(udfName, signatureFunc, optArgc) \
BEGIN_ARROW_UDF_IMPL(udfName##_BlocksImpl, signatureFunc, optArgc, true) \
UDF_IMPL(udfName, builder.SimpleSignature<signatureFunc>().OptionalArgs(optArgc).SupportsBlocks().IsStrict();, ;, ;, "", "", udfName##_BlocksImpl)
UDF_IMPL(udfName, builder.SimpleSignature<signatureFunc>().SupportsBlocks().IsStrict().OptionalArgs(optArgc);, ;, ;, "", "", udfName##_BlocksImpl)

#define END_ARROW_UDF(udfNameBlocks, exec) \
inline bool udfNameBlocks::DeclareSignature(\
Expand Down

0 comments on commit a2b08e0

Please sign in to comment.