Skip to content

Commit

Permalink
return implicit query params type into feature flag (#8063)
Browse files Browse the repository at this point in the history
  • Loading branch information
VPolka authored Aug 26, 2024
1 parent cf0bcd6 commit 1a88bb4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion ydb/core/kqp/session_actor/kqp_query_state.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ class TKqpQueryState : public TNonCopyable {
, StartedAt(startedAt)
{
RequestEv.reset(ev->Release().Release());
if (tableServiceConfig.GetEnableImplicitQueryParameterTypes() && !RequestEv->GetYdbParameters().empty()) {
bool enableImplicitQueryParameterTypes = tableServiceConfig.GetEnableImplicitQueryParameterTypes() ||
AppData()->FeatureFlags.GetEnableImplicitQueryParameterTypes();
if (enableImplicitQueryParameterTypes && !RequestEv->GetYdbParameters().empty()) {
QueryParameterTypes = std::make_shared<std::map<TString, Ydb::Type>>();
for (const auto& [name, typedValue] : RequestEv->GetYdbParameters()) {
QueryParameterTypes->insert({name, typedValue.Gettype()});
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/protos/feature_flags.proto
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ message TFeatureFlags {
optional bool EnableSeparationComputeActorsFromRead = 90 [default = false];
optional bool EnablePQConfigTransactionsAtSchemeShard = 91 [default = false];
optional bool EnableScriptExecutionOperations = 92 [default = true];
reserved 93; // optional bool EnableImplicitQueryParameterTypes = 93 [default = false];
optional bool EnableImplicitQueryParameterTypes = 93 [default = false];
optional bool EnableForceImmediateEffectsExecution = 94 [default = false];
optional bool EnableTopicSplitMerge = 95 [default = false];
optional bool EnableChangefeedDynamoDBStreamsFormat = 96 [default = true];
Expand Down

0 comments on commit 1a88bb4

Please sign in to comment.