small transfer meta processing correction

ydb-platform · Jul 8, 2024 · 15cf9ec · 15cf9ec
1 parent bc77d99
commit 15cf9ec
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/ydb/core/tx/schemeshard/olap/operations/alter/in_store/transfer/update.cpp b/ydb/core/tx/schemeshard/olap/operations/alter/in_store/transfer/update.cpp
@@ -30,7 +30,7 @@ NKikimr::TConclusionStatus TInStoreShardsTransfer::DoInitializeImpl(const TUpdat
         for (auto&& i : alter.GetSourceTabletIds()) {
             destinationSession.MutableTransferContext()->AddSourceTabletIds(i);
         }
-        DestinationSessions.emplace_back(destinationSession);
+        AFL_VERIFY(DestinationSessions.emplace(destinationSession.GetTransferContext().GetDestinationTabletId(), destinationSession).second);
         AFL_VERIFY(ShardIdsUsage.emplace(alter.GetDestinationTabletId()).second);
     }
     const auto& inStoreOriginal = context.GetOriginalEntityAsVerified<TInStoreTable>();

diff --git a/ydb/core/tx/schemeshard/olap/operations/alter/in_store/transfer/update.h b/ydb/core/tx/schemeshard/olap/operations/alter/in_store/transfer/update.h
@@ -10,7 +10,7 @@ namespace NKikimr::NSchemeShard::NOlap::NAlter {
 class TInStoreShardsTransfer: public TInStoreTableUpdate {
 private:
     using TBase = TInStoreTableUpdate;
-    std::vector<NKikimrColumnShardDataSharingProto::TDestinationSession> DestinationSessions;
+    THashMap<ui64, NKikimrColumnShardDataSharingProto::TDestinationSession> DestinationSessions;
     std::shared_ptr<TInStoreTable> TargetInStoreTable;
     std::set<ui64> ShardIdsUsage;
 
@@ -29,13 +29,9 @@ class TInStoreShardsTransfer: public TInStoreTableUpdate {
     virtual TConclusionStatus DoInitializeImpl(const TUpdateInitializationContext& context) override;
 
     virtual TString DoGetShardTxBodyString(const ui64 tabletId, const TMessageSeqNo& /*seqNo*/) const override {
-        for (auto&& i : DestinationSessions) {
-            if (i.GetTransferContext().GetDestinationTabletId() == tabletId) {
-                return i.SerializeAsString();
-            }
-        }
-        AFL_VERIFY(false);
-        return "";
+        auto it = DestinationSessions.find(tabletId);
+        AFL_VERIFY(it != DestinationSessions.end());
+        return it->second.SerializeAsString();
     }
 
     virtual std::set<ui64> DoGetShardIds() const override {