Specific integer types and limit-offset support #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekby
reviewed
Feb 6, 2024
| @@ -87,15 +87,30 @@ def visit_FLOAT(self, type_: sa.FLOAT, **kw): | |||
| def visit_BOOLEAN(self, type_: sa.BOOLEAN, **kw): | |||
There was a problem hiding this comment.
I have a doubt about visit_uuid and implicit convert uuid to UTF8: YDB has own uuid type. Now it can't stored to a table, but it can be (and will sometime) in future. Then convert from uuid to UTF8 will see strange.
I suggest to not convert uuid to UTF-8 into SDK and suggest users to the conversion in customers code. It is simple as str(var)
There was a problem hiding this comment.
Discussed in offline: will solved in a separate PR
rekby
reviewed
Feb 6, 2024
| select._offset_clause, types.UInt64, skip_types=(types.UInt64, types.UInt32, types.UInt16, types.UInt8) | ||
| ) | ||
| if select._limit_clause is None: | ||
| text += "\n LIMIT NULL" |
There was a problem hiding this comment.
Why do you need explicit LIMIT NULL?
There was a problem hiding this comment.
Discussed in offline: it is needed to use OFFSET without LIMIT
rekby
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dialect don't support native usage of
limit().offset()methods due to type collision: sqlalchemy by default provide all integer bound variables as Int64, when YQL requires UInt variable to be passed to LIMIT OFFSET.In this PR
In this PR I add the optional type casting to the LIMIT OFFSET clause to allow native usage of SQLalchemy methods related to.
Bonus
Dialect was enriched with all integer YDB types.