Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cancel logic during SessionPool.acquire() #537

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix cancel logic during SessionPool.acquire() #537

merged 1 commit into from
Jan 13, 2025

Conversation

MBogda
Copy link
Contributor

@MBogda MBogda commented Dec 20, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

In case of a cancel during SessionPool.acquire() is waiting for a free session, a sub-task is not canceled, so session is acquired and lost.

What is the new behavior?

Sub-task self._active_queue.get() is cancelled in case of asyncio.CancelledError error during execution of ydb.aio.table.SessionPool._get_session_from_queue().

Other information

Script to reproduce

You need to have a running YDB at localhost:2135.
Script will never stop because of the bug, so you need to stop it manually (e.g. hit ctrl+C).

import asyncio

import ydb


async def main():
    async with ydb.aio.Driver(endpoint="localhost:2135", database="/local") as driver:
        await driver.wait()
        pool = ydb.aio.SessionPool(driver, size=1)
        asyncio.create_task(log(pool))
        await asyncio.gather(first_connection(pool), second_connection(pool), third_connection(pool))
        print("End of execution")
        await asyncio.sleep(1)


async def first_connection(pool: ydb.aio.SessionPool):
    print("First session acquiring")
    session = await pool.acquire()
    print("First session acquired")
    await asyncio.sleep(5)
    print("First session releasing")
    await pool.release(session)
    print("First session released")


async def second_connection(pool: ydb.aio.SessionPool):
    await asyncio.sleep(1)
    print("Second session acquiring")
    try:
        session = await asyncio.wait_for(pool.acquire(), timeout=1)
        # will not be called because of TimeoutError
        print("Second session acquired")
        print("Second session releasing")
        await pool.release(session)
        print("Second session released")
    except asyncio.TimeoutError:
        print("Second session acquiring aborted")
    finally:
        print("Second function closed")


async def third_connection(pool: ydb.aio.SessionPool):
    await asyncio.sleep(2)
    print("Third session acquiring")
    session = await pool.acquire()
    print("Third session acquired")
    print("Third session releasing")
    await pool.release(session)
    print("Third session released")


async def log(pool):
    while True:
        print(f"Pool size {pool._active_queue.qsize()}/{pool._size} : Active count {pool._active_count}")
        await asyncio.sleep(0.5)


asyncio.run(main())

Output before the changes

Pool size 0/1 : Active count 0
First session acquiring
First session acquired
Pool size 0/1 : Active count 1
Second session acquiring
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Third session acquiring
Second session acquiring aborted
Second function closed
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
First session releasing
First session released
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Traceback (most recent call last):
  File "/Users/ya-bogdan/.pyenv/versions/3.11.8/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ya-bogdan/.pyenv/versions/3.11.8/lib/python3.11/asyncio/base_events.py", line 654, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/ya-bogdan/Library/Application Support/JetBrains/PyCharm2023.3/scratches/three_requests_pool.py", line 11, in main
    await asyncio.gather(first_connection(pool), second_connection(pool), third_connection(pool))
  File "/Users/ya-bogdan/Library/Application Support/JetBrains/PyCharm2023.3/scratches/three_requests_pool.py", line 45, in third_connection
    session = await pool.acquire()
              ^^^^^^^^^^^^^^^^^^^^
  File "/Users/ya-bogdan/projects/ydb-python-sdk/ydb/aio/table.py", line 606, in acquire
    session = await self._get_session_from_queue(timeout)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ya-bogdan/projects/ydb-python-sdk/ydb/aio/table.py", line 566, in _get_session_from_queue
    done, _ = await asyncio.wait((task_wait, task_should_stop), return_when=asyncio.FIRST_COMPLETED)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ya-bogdan/.pyenv/versions/3.11.8/lib/python3.11/asyncio/tasks.py", line 428, in wait
    return await _wait(fs, timeout, return_when, loop)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/ya-bogdan/.pyenv/versions/3.11.8/lib/python3.11/asyncio/tasks.py", line 535, in _wait
    await waiter
asyncio.exceptions.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/ya-bogdan/Library/Application Support/JetBrains/PyCharm2023.3/scratches/three_requests_pool.py", line 58, in <module>
    asyncio.run(main())
  File "/Users/ya-bogdan/.pyenv/versions/3.11.8/lib/python3.11/asyncio/runners.py", line 190, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/Users/ya-bogdan/.pyenv/versions/3.11.8/lib/python3.11/asyncio/runners.py", line 123, in run
    raise KeyboardInterrupt()
KeyboardInterrupt

Output after the changes

Pool size 0/1 : Active count 0
First session acquiring
First session acquired
Pool size 0/1 : Active count 1
Second session acquiring
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Third session acquiring
Second session acquiring aborted
Second function closed
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
Pool size 0/1 : Active count 1
First session releasing
First session released
Third session acquired
Third session releasing
Third session released
End of execution
Pool size 1/1 : Active count 1
Pool size 1/1 : Active count 1

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

🌋 Here are results of SLO test for sync-query:

Operation Success Rate

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Success Rate, %" 0 --> 111
    line [100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.908,99.895,99.895,99.895,99.895,99.895,99.895,99.895,99.895,99.894,99.894,99.894,99.894,99.894,99.894,99.894,99.894,99.894,99.894,99.894,99.894,99.894,99.893,99.893,99.893,99.893,99.892,99.892,99.892,99.987,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.991,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.983,99.992,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]
Loading 
---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "	Time, m" 0 --> 10
    y-axis "Success Rate, %" 0 --> 111
    line [100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.451,99.449,99.437,99.439,99.441,99.458,99.458,99.458,99.458,99.458,99.458,99.458,99.458,99.437,99.44,99.441,99.458,99.458,99.458,99.458,99.446,99.448,99.458,99.458,99.467,99.47,99.469,99.47,99.471,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]
Loading

Operations Per Second

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 27 --> 953
    line [784.536,812.818,840.961,859.138,858.276,858.207,859.483,861.897,862.621,861.069,863.103,862.345,861.759,861.759,861.828,861.931,863.414,865.552,865.345,856.931,850,849,849.552,847.552,846.069,845.552,843.034,842.069,841.276,840.276,838.966,838.276,837.483,838.414,839.828,838.414,834.448,833.897,833.69,831.724,831.379,830.379,831.069,832.448,831.586,833.138,829.483,828.069,835.931,841.862,842.552,841.483,841.621,839.586,839.138,840.966,843.724,843.31,842.897,843.897,844.241,843.414,841.897,839.172,839.655,840.759,840.862,842.586,842.655,842.828,843.517,841.759,840.69,841.897,839,840.69,841.207,842.31,842.483,841.931,824.621,823.414,824.138,823.828,823.103,819.241,818.897,819,817.448,816.586,814.207,814.31,814.345,814.793,814.724,813.931,810.793,810.759,809.931,809.828,811.552,810,807.172,806.069,803.931,802.931,801.586,800.759,800.379,816.966,817.276,816.276,816.138,816.483,816.138,816.69,816.276,817.31,819.276,821.862,821.276,822.207,818.621,818.517,819,819.724,819.034,819,818.414,816.379,817,816.966,816.172,817.345,817.897,820,820.448,821.793,825.586,824.655,807.724,807,806.897,807,806.759,807.103,807.31,805.172,808.448,807.931,806.897,809.069,807.379,807.724,810.862,810.931,812.207,812.759,812.897,813.759,817.759,819.207,817.552,816.621,815.414,815.31,815.414,813.621,815.241,832.069,832.621,833.103,836.31,835.552,835.414,835.724,836.103,832.31,833.517,834.586,833.241,837.345,836.345,832.862,832.862,832.379,832.759,832.31,831.172,831.276,830.207,831.897,832.931,832.034,834.276,833.276,831.034,832.172,835.069,835.379,833.103,829.828,830.345,830.31,832.276,833.276,837.103,836.931,836.345,836.759,832,832.655,833.586,835.897,839.069,838.345,838.862,838.828,835.69,837.552,835.897,835.897,836.241,837,836.724,840.414,840.103,835.655,835.69,836.828,838.276,837.379,840.034,836.379,839.69,836.241,836.69,836.655,836.897,839.207,838.793,838.241,838.862,834.931,836.207,836.138,836.448,836.931,837.828,840.448,840.966,840.724,836.586,836.552,834.207,833.414,835.862,835.759,836.621,836,835.897,833.345,833.724,830.069,829.897,829.103,829.828,830.172,831.655,832,831.931,828.793,828.966,827.724,827.138,830.276,829.759,828.241,826.103,824.828,824.828,825.621,828.552,828,828.345,826.31,827.069,827.069,825.138,825.621,827.069,826.621,829.034,829.103,828.862,827.793,828.103,826.069,828.793,828.621,832.31,831.759,832.103,832.931,829.414,829.276,829.483,829.897,830,829.655,830.897,830.103,830.793,832.655,834.069,833.828,833.793,836.379,837.759,836.931,838.345,838.31,841.414,841.069,841.586,841.276,840.207,837.621,837.69,833,834.034,832.207,832.448,834.931,834.828,834.621,833.621,833.517,837.552,836.931,835.448,833.414,831.724,830.759,830.655,833.379,832.655,831.103,829.966,829.31,826.207,825.276,825.897,824.69,824.138,824.793,825.069,824.862,826.759,830.034,831.379,829.586,828,826.621,827.069,828.241,830.172,827.345,829,829.966,831.345,829.862,831.276,830.552,827.517,827.724,827.138,828.103,828.897,828.862,826.621,829.138,832.31,831.793,832.586,834.586,834.897,834.207,831.31,830.517,832.034,830.552,831.862,830.862,830.966,831.034,829.793,827.828,826.552,825.724,826.414,828.276,828.034,828.138,827.759,827.172,827.517,826.966,826.448,826.414,826.379,823.103,823.379,820.931,818.517,818.586,818.793,818.621,819.138,819.069,819.414,819.483,821.345,820.138,817.552,816.931,817.241,817.103,820.345,820.759,817.207,817.241,818.241,816.69,821.138,820.069,820.793,821.31,821.793,818.414,822.586,823.034,823.862,824,823.69,824.69,824.345,826.276,827.483,826.759,826.483,824.69,825.138,826.345,828.034,828.621,832.586,830.241,830.103,830.552,830.966,829.724,831.655,830.241,831.103,829.69,829.69,829.655,829.793,826.483,826.172,829.069,827.517,827.345,826.862,826.828,824.862,825.138,827.379,829.759,830.276,829.828,829.621,827.655,827.414,823.966,823.862,823.621,824.172,823.759,823.448,826.276,825.414,825.552,826.276,826.552,826.207,827.31,828.552,830.586,829.828,832.034,831.448,830.586,829.655,829.586,826.655,825.379,823.793,822.379,823.034,822.276,822.448,825.172,827.862,827.862,828.345,827.379,828.483,829.31,828.448,827.793,826.759,825.966,825.034,824.517,824.103,823.207,820.69,818.069,817.31,820.276,819.621,819.655,819.793,820.759,822.862,823.034,822.931,823.931,823.897,827.207,825.241,822.586,820.793,822.241,822.621,822.448,821.069,818.862,821.31,821.069,821.034,821.138,821.241,821.138,821.207,822.034,823.483,825.828,822.621,826.724,826.828,826.552,824.517,823.069,822.759,824.034,823.621,823.621,820.931,819.931,818.655,823.034,793.069,765.138,736.621,709.483,681.207,650.276,622.759,595.345,567.862,540.172,512,483.414,455.552,426.862,395.966,368.793,337.448,309.828,282.172,256.103,227.586,199.034,170.724,142.172,114.483,86.552,58.207,30.793]
Loading 
---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 1 --> 103
    line [84.531,87.947,91.222,93.448,93.414,93.414,93.414,90.034,90.069,91.31,91.414,91.759,91.69,91.621,91.828,91.724,91.966,88.759,89.345,89.69,89.897,89.897,89.897,89.793,90.517,90.552,90.586,90.448,90.034,89.966,89.552,89.759,89.621,88.655,86.724,86.69,90.103,90.069,90.069,90.069,90.069,90.069,87.483,86.828,86.759,83.379,86.724,86.724,86.759,86.724,86.724,86.724,86.828,89.31,89.172,88.862,86.31,86.759,86.828,87.172,87.034,87.138,88.138,90.069,90.103,89.621,89.483,86.724,86.69,86.724,86.724,87.897,88.241,86.655,90,88.448,88.034,88.172,88,87.793,87.897,87.621,85.793,86.069,86.345,89.034,89,89,89,89,89,89,89,85.724,86.207,86.345,89.103,89.138,89.103,89.069,87.069,87.379,89.034,89.069,90.621,91.034,90.897,91.069,91.276,91.172,91.483,93.31,93.31,91.897,91.517,90.69,90.621,89.931,87.345,87.034,86.655,86.621,89.862,89.862,89.897,89.897,89.862,89.862,89.931,93.379,93.414,93.448,92.966,92.931,91.69,90.414,90.034,90.069,87.552,86.828,87.172,86.897,88.172,88.552,89.31,89.379,90.138,92.655,89.586,89.966,90,90.034,90,89.966,86.621,86.655,86.655,86.621,86.586,86.552,83.138,83.655,83.69,84.931,86.207,86.586,85.517,85.724,86.448,86.103,86.379,86.517,83.172,83.241,83.241,83.172,83.241,86.621,86.621,86.621,86.621,83.379,83.379,86.724,86.724,86.724,86.724,86.724,86.724,86.828,86.103,86.207,85.276,84.897,83.483,84.552,86.759,86.759,83.379,83.379,83.379,86.724,86.724,86.724,83.379,83.31,79.931,79.931,79.931,79.931,83.172,83.172,81.655,79.793,76.379,76.379,76.379,76.379,79.655,80.345,80.241,81.172,81.552,79.621,79.517,76.241,76.241,79.621,79.621,79.621,79.138,79.172,76.276,79.552,76.724,79.828,79.655,79.655,79.724,79.655,79.724,81.172,79.655,83.069,83.069,83.069,83.069,83.069,80.483,79.69,76.966,77.345,80.345,80.276,83.379,83.172,83.172,83.207,83.207,83.759,83.759,86.655,86.759,89.655,89.828,89.897,89.966,89.897,87.483,87.621,86.793,90.138,90.172,90.103,90.138,86.793,86.724,89.31,90.103,92.828,92.448,92.793,89.586,89.931,90.172,90.069,90.034,90.069,89.966,89.931,89.931,89.897,86.517,86.655,86.759,86.69,86.69,88.103,85.586,86.448,83.103,83.069,83.138,83.103,86.448,86.517,86.31,86.483,86.207,86.103,85.69,86.483,86.379,82.931,82.069,82.345,81.828,81.034,79.69,79.655,79.655,79.621,76.172,76.207,76.241,76.207,77.241,79.552,79.586,82.966,82.966,82.966,82.966,79.69,79.724,79.931,79.759,80.034,76.724,77.138,79.69,79.724,83.138,84.103,83.828,80.966,81.759,83.138,83.172,83.172,86.586,86.759,86.586,86.586,86.621,86.655,86.655,86.655,86.655,83.31,83.345,83.379,86.655,86.621,86.621,85.172,83.241,86.621,83.207,82.517,82.172,81.586,80.552,80.586,84.069,83.966,83.862,83.31,83.276,83.207,86.483,83.241,79.966,79.793,79.759,76.345,76.345,76.345,79.69,79.655,79.621,79.621,79.621,79.621,79.897,79.724,79.793,83.207,83.897,84.241,84.793,82.414,82.379,82.241,82.379,82.448,83,83.103,83.172,83.138,83.172,86.414,86.586,86.621,90.034,90.034,90.034,88.966,88.828,88.759,88.724,88.724,86.793,87.966,90.069,90.034,90.034,90.034,86.69,86.724,90.138,90.138,90.138,90.138,86.793,86.793,86.724,86.724,86.724,90.069,87.069,86.897,86.759,86.828,86.759,86.759,87.862,84.586,84.655,84.69,84.69,86.621,86.621,85.034,85.069,83.345,79.931,83.276,83.276,83.276,83.276,83.276,83.276,83.276,83.345,83.276,83.276,83.276,83.276,86.276,86.448,83.345,83.276,83.345,83.345,83.31,86.724,84.897,83.345,80.759,80.483,80.172,82.172,81.759,83.724,87.103,87.034,86.655,86.655,86.655,86.655,83.241,83.172,83.103,83.172,83.172,83.172,83.172,81.655,79.793,79.621,79.621,79.621,79.621,79.621,79.621,81.448,83,85.586,85.862,86.172,85.759,86.138,82.517,79.138,79.207,79.586,79.586,79.586,79.586,79.621,83.069,83.069,83.069,83.069,83.069,83.069,84.586,86.448,89.862,89.862,86.517,86.517,86.552,86.552,86.552,83.172,83.172,83.172,83.172,83.172,79.759,79.724,83.138,83.138,83.138,83.138,83.138,83.138,86.517,83.138,83.138,83.138,83.138,83.138,83.138,83.138,83.138,83.138,80.103,83.069,79.69,79.655,79.655,79.655,83.034,83.034,83.034,83.034,83.034,86.448,88.966,88.724,86.586,83.138,79.69,76.241,72.793,69.345,69.241,65.793,62.345,58.897,55.448,52,48.552,45.103,41.655,41.241,38.172,38.103,34.655,31.207,27.759,24.31,20.862,17.414,13.966,10.517,7.069,4.517,1.31]
Loading

95th Percentile Latency

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 0 --> 30
    line [25.994,26.092,25.98,26.028,26.017,26.23,26.41,26.193,26.05,26.231,26.125,26.391,26.336,26.265,26.278,26.396,26.307,25.847,25.743,25.852,25.871,25.904,25.58,25.849,25.956,25.971,25.783,25.66,25.402,25.075,24.853,25.255,25.159,24.961,24.564,24.408,24.621,24.743,24.728,25.042,24.855,24.851,24.52,24.182,23.799,23.29,23.841,23.946,23.833,24.243,24.164,24.289,23.84,24.256,24.63,24.646,24.292,24.377,24.498,24.414,24.349,24.266,24.685,24.75,24.976,24.977,24.695,24.249,24.039,23.996,23.898,24.25,24.155,24.004,24.476,24.258,24.038,23.796,23.332,23.6,23.452,23.662,23.075,22.421,21.892,22.153,21.875,21.551,21.535,21.024,21.299,20.767,20.519,19.965,19.929,19.895,19.922,19.9,19.878,19.844,19.81,19.819,19.833,19.805,19.806,19.808,19.811,19.797,19.769,19.763,19.776,19.795,19.808,19.801,19.79,19.797,19.803,19.801,19.778,19.744,19.752,19.759,19.81,19.832,19.849,19.83,19.84,19.839,19.875,19.876,19.894,19.89,19.895,19.896,19.875,19.854,19.851,19.833,19.793,19.791,19.821,19.774,19.774,19.769,19.781,19.763,19.746,19.754,19.706,19.696,19.695,19.678,19.674,19.669,19.617,19.595,19.593,19.584,19.589,19.548,19.483,19.465,19.474,19.479,19.49,19.469,19.451,19.473,19.459,19.436,19.473,19.471,19.443,19.434,19.449,19.451,19.446,19.489,19.495,19.485,19.499,19.439,19.445,19.482,19.484,19.48,19.474,19.484,19.497,19.497,19.512,19.491,19.497,19.497,19.498,19.518,19.537,19.526,19.486,19.478,19.492,19.521,19.503,19.498,19.459,19.475,19.422,19.422,19.421,19.409,19.458,19.431,19.432,19.406,19.362,19.357,19.34,19.34,19.381,19.367,19.37,19.353,19.35,19.317,19.319,19.281,19.282,19.335,19.336,19.329,19.343,19.365,19.319,19.364,19.338,19.381,19.374,19.384,19.38,19.372,19.395,19.412,19.396,19.443,19.434,19.445,19.448,19.462,19.427,19.422,19.402,19.416,19.491,19.478,19.503,19.515,19.488,19.492,19.491,19.482,19.475,19.527,19.527,19.548,19.56,19.561,19.548,19.536,19.521,19.531,19.507,19.563,19.573,19.58,19.578,19.553,19.543,19.583,19.591,19.629,19.616,19.597,19.558,19.582,19.576,19.593,19.588,19.585,19.575,19.579,19.577,19.572,19.523,19.537,19.529,19.547,19.546,19.56,19.528,19.564,19.505,19.526,19.527,19.509,19.532,19.541,19.523,19.523,19.523,19.521,19.5,19.539,19.535,19.496,19.468,19.469,19.456,19.455,19.434,19.433,19.449,19.459,19.395,19.426,19.409,19.424,19.425,19.447,19.447,19.513,19.492,19.515,19.533,19.501,19.494,19.513,19.511,19.513,19.473,19.491,19.496,19.517,19.551,19.574,19.584,19.57,19.588,19.605,19.609,19.592,19.627,19.637,19.63,19.634,19.634,19.652,19.663,19.655,19.631,19.581,19.558,19.57,19.595,19.605,19.601,19.585,19.56,19.597,19.551,19.545,19.52,19.518,19.497,19.5,19.538,19.531,19.562,19.539,19.541,19.542,19.575,19.526,19.487,19.5,19.482,19.44,19.435,19.438,19.467,19.472,19.46,19.497,19.492,19.502,19.505,19.507,19.515,19.556,19.556,19.553,19.553,19.536,19.527,19.521,19.525,19.512,19.536,19.545,19.551,19.565,19.569,19.618,19.617,19.645,19.688,19.678,19.687,19.69,19.684,19.691,19.673,19.664,19.643,19.666,19.68,19.679,19.686,19.687,19.653,19.665,19.701,19.698,19.69,19.703,19.651,19.631,19.632,19.638,19.612,19.657,19.597,19.582,19.566,19.551,19.55,19.545,19.553,19.518,19.507,19.525,19.539,19.573,19.574,19.574,19.555,19.528,19.504,19.534,19.523,19.529,19.525,19.528,19.511,19.511,19.519,19.518,19.52,19.524,19.519,19.588,19.606,19.567,19.587,19.585,19.582,19.585,19.614,19.597,19.554,19.514,19.496,19.485,19.497,19.514,19.538,19.556,19.562,19.55,19.55,19.567,19.578,19.543,19.55,19.549,19.534,19.522,19.519,19.519,19.468,19.426,19.437,19.421,19.443,19.438,19.444,19.454,19.502,19.528,19.558,19.571,19.585,19.58,19.599,19.548,19.529,19.52,19.537,19.524,19.52,19.509,19.513,19.55,19.574,19.593,19.603,19.608,19.616,19.634,19.673,19.699,19.696,19.636,19.658,19.653,19.648,19.615,19.568,19.593,19.579,19.567,19.573,19.522,19.526,19.559,19.575,19.552,19.555,19.534,19.551,19.597,19.551,19.532,19.543,19.536,19.555,19.54,19.543,19.534,19.537,19.518,19.578,19.515,19.541,19.55,19.577,19.622,19.605,19.598,19.616,19.617,19.655,19.685,19.709,19.678,19.702,19.713,19.73,19.719,19.705,19.757,19.753,19.728,19.724,19.71,19.708,19.735,19.735,19.732,19.784,19.758,19.876,19.815,19.803,19.757,19.759,19.741,19.804,19.723,19.638,19.578,19.672,18.993,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]
Loading 
---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 0 --> 32
    line [27.13,26.893,26.705,26.771,27.042,26.375,26.549,26.445,26.293,26.947,26.509,27.363,26.985,27.397,26.679,26.706,27.818,28.356,27.963,27.36,27.952,29.073,28.368,28.271,28.338,28.208,28.076,27.604,27.045,27.725,27.829,27.518,27.287,27.266,27.769,27.327,27.517,27.263,25.7,26.578,25.851,26.293,26.255,27.012,27.446,26.179,25.855,26.898,26.6,25.698,24.161,24.337,24.306,23.75,24.14,24.057,24.284,24.327,23.213,22.914,23.149,23.306,22.614,21.401,21.18,20.012,19.992,20.527,19.971,19.97,19.949,20.129,19.938,19.897,19.892,19.873,19.784,19.776,19.786,19.778,19.762,19.773,19.807,19.846,19.785,19.791,19.821,19.884,19.895,19.929,19.962,19.928,19.949,19.906,19.909,19.917,20.12,19.98,19.956,19.956,19.901,19.973,19.982,19.981,20.535,21.711,21.114,21.489,21.207,21.27,20.739,20.154,19.996,20.389,21.36,20.56,19.955,19.954,19.934,19.883,19.961,20.095,20.609,21.878,22.266,21.456,22.277,22.472,23.388,23.099,23.614,22.9,23.219,22.5,22.302,23.062,22.99,23.164,22.796,23.213,23.848,22.609,22.798,21.883,22.641,23,21.993,21.815,21.761,21.224,20.564,19.979,19.98,19.928,19.896,19.868,19.843,19.777,19.742,19.652,19.689,19.645,19.675,19.649,19.63,19.699,19.688,19.688,19.656,19.639,19.701,19.688,19.675,19.697,19.659,19.706,19.755,19.776,19.76,19.772,19.851,19.786,19.812,19.783,19.807,19.872,19.925,20.527,20.527,20.492,20.965,20.472,20.791,21.148,19.986,19.992,20.516,20.048,19.988,19.961,20.025,19.964,19.902,19.916,19.924,19.848,19.829,19.895,19.895,19.881,19.852,19.827,19.84,19.82,19.784,19.704,19.664,19.649,19.652,19.614,19.615,19.554,19.554,19.543,19.529,19.495,19.507,19.596,19.698,19.655,19.732,19.79,19.796,19.783,19.79,19.791,19.755,19.756,19.689,19.667,19.716,19.742,19.753,19.74,19.738,19.693,19.731,19.72,19.774,19.813,19.858,19.919,19.88,19.882,19.88,19.919,19.819,19.768,19.744,19.707,19.658,19.679,19.687,19.683,19.669,19.645,19.643,19.675,19.706,19.708,19.698,19.723,19.71,19.735,19.792,19.781,19.769,19.721,19.72,19.694,19.646,19.685,19.705,19.7,19.646,19.661,19.613,19.652,19.728,19.721,19.705,19.708,19.72,19.741,19.73,19.722,19.655,19.681,19.655,19.655,19.626,19.639,19.65,19.587,19.616,19.635,19.676,19.649,19.65,19.631,19.633,19.648,19.624,19.65,19.627,19.607,19.575,19.443,19.442,19.474,19.419,19.42,19.397,19.423,19.446,19.483,19.453,19.532,19.504,19.509,19.51,19.539,19.552,19.516,19.51,19.463,19.44,19.424,19.425,19.399,19.408,19.476,19.486,19.523,19.537,19.544,19.594,19.62,19.605,19.666,19.664,19.662,19.663,19.661,19.674,19.648,19.561,19.565,19.613,19.618,19.55,19.612,19.631,19.622,19.636,19.704,19.738,19.722,19.737,19.773,19.723,19.72,19.736,19.758,19.783,19.758,19.733,19.728,19.738,19.701,19.715,19.697,19.681,19.647,19.678,19.706,19.704,19.607,19.642,19.701,19.66,19.661,19.723,19.728,19.71,19.726,19.727,19.739,19.652,19.674,19.676,19.66,19.626,19.583,19.573,19.588,19.549,19.495,19.516,19.532,19.531,19.531,19.567,19.616,19.62,19.618,19.628,19.607,19.583,19.563,19.609,19.601,19.672,19.645,19.639,19.674,19.664,19.687,19.672,19.687,19.675,19.674,19.745,19.839,19.83,19.855,19.928,19.928,19.853,19.836,19.846,19.8,19.763,19.739,19.752,19.789,19.746,19.76,19.809,19.759,19.784,19.715,19.705,19.693,19.668,19.655,19.667,19.658,19.604,19.655,19.663,19.558,19.495,19.495,19.538,19.539,19.583,19.66,19.634,19.642,19.688,19.685,19.774,19.749,19.762,19.759,19.768,19.717,19.728,19.672,19.679,19.684,19.692,19.645,19.669,19.719,19.744,19.763,19.707,19.712,19.727,19.711,19.713,19.645,19.583,19.529,19.451,19.514,19.481,19.485,19.487,19.428,19.601,19.575,19.666,19.681,19.676,19.676,19.715,19.759,19.819,19.904,20.262,20.335,19.975,19.974,20.41,20.41,20.41,21.388,21.376,21.988,23.034,23.034,23.034,23.624,23.43,22.945,23.703,23.408,23.588,21.914,22.728,21.692,21.038,21.038,20.823,20.823,21.512,20.823,19.952,19.894,19.894,19.874,19.862,19.813,19.853,19.866,19.828,19.882,19.838,19.85,20.112,20.357,21.068,21.298,21.965,21.524,21.298,21.202,21.321,20.623,20.882,20.882,20.636,21.104,20.634,19.93,19.968,19.968,19.957,19.988,19.967,19.967,20.112,19.992,20.388,20.95,19.991,19.993,19.942,19.779,19.8,19.766,19.735,19.761,19.666,19.697,19.711,19.676,19.679,19.709,19.74,19.818,19.691,19.643,19.773,19.593,19.643,19.612,18.917,19.25,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

🌋 Here are results of SLO test for sync-table:

Operation Success Rate

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Success Rate, %" 89 --> 111
    line [100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,99.985,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100]
Loading 
---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "	Time, m" 0 --> 10
    y-axis "Success Rate, %" 89 --> 111
    line [100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100,100]
Loading

Operations Per Second

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 799 --> 1087
    line [909.56,941.713,977.931,977.069,977.862,978.724,979.448,978.828,982.276,980.897,979.172,978.207,980,979.517,979.345,975.724,976.138,977.069,976.793,973.172,974.655,974.241,973.69,973.483,973.517,975.276,979.345,980.172,976.207,959.655,954.897,953.517,953.69,954.621,952.103,950.034,949,950.414,950.931,949.483,952.276,947.69,946.241,945.172,950,950.345,949.379,945.517,946.31,945.138,944.552,945.276,946.069,945.172,944.517,946.276,944.897,948.517,961.069,965.414,966.897,968.241,966.621,968.034,969.862,971.138,969.103,969.793,972.897,973.69,977.966,979.448,980.069,979.103,978.828,978.793,980.724,979.31,976.138,966.103,966.034,966.103,968.034,968.517,969.138,969.793,970,974.31,975.931,976.586,942,937.138,936.31,936.655,937.172,937.931,936.517,937.345,935,934.241,934.552,935.138,932.931,934.103,933.276,930.69,917.414,922.034,932.897,927.241,926.345,926.345,924.793,925.793,924.586,911.069,910.621,910.345,910.586,941.759,947.793,947.552,948.828,949.069,945.379,940.276,940.207,942.414,943.448,943.103,942.966,945.483,944.759,946.31,950.931,965.655,965.655,939.31,945.034,945.931,944.69,939.655,938.759,939.897,953.414,953.862,954.138,953.897,956.655,956.172,924.655,918.483,913.276,917.069,921.31,921.793,916.931,918.207,914.31,912.828,912.276,912.586,912.517,911.862,911.207,910.655,937.276,936,934.69,938.448,938.621,938.552,933.517,930.172,929.69,930.483,918.483,918.897,918,950.621,954.448,959.759,960.655,961.724,961.034,965.552,963.172,965.759,968.586,968.448,967.241,967.552,961.586,963.586,959.69,949.241,949.621,950.034,947.69,952.931,952.931,955.379,958.793,958.414,958.138,970.172,968.069,967.793,969.241,970.241,970.069,967.793,967.517,968.103,967.034,955.034,956.379,955.034,955.793,956.621,956.379,963,961.655,966.069,976.207,956.966,958,956.966,956.897,957.103,959.241,959.862,959.207,956.621,956.448,957.931,957.655,949.069,949.276,949.379,946.276,946.138,942.828,942.931,956.828,955.724,954.414,945.103,943.345,943.793,942.862,943.69,943,942.655,962.897,960.862,962.414,963.483,963.517,962.759,952.724,953.483,952.103,949.069,950.448,950.793,958,957.31,957.552,961.655,961.621,963.241,963.379,962.379,963.552,963.69,973.069,974.828,974.379,975.414,973.069,972.897,972.828,969.552,973.759,972.379,972.966,972.517,972.483,981.448,980.379,982.586,978.793,977.621,979.103,978.931,979.586,979.379,979.586,980.586,981.897,983.069,975.552,976.966,977.966,978.034,976.966,976.586,975.655,976.862,976.105,975.621,979.931,978.897,977.862,969.793,969.172,969.897,970.172,971.379,973.172,967.414,967.483,967.483,967.483,967.448,967.483,967.483,967.483,967.483,965.414,972.828,973.103,939.414,939.276,940.345,940.724,941.552,941.862,943.513,944.483,943.241,941.966,943.69,951.345,952.207,952.759,952.828,953.483,952.931,965.655,965.586,965.586,958.552,957.448,955.517,955.483,955.241,955.31,956.138,958.069,956.379,987.241,987.379,986.172,985.138,984.966,985.138,984.034,981.897,979,979.483,978.759,978.931,979.069,979.069,979.069,980.103,980.138,978.172,978.103,977.241,976.414,978.345,978.621,979.759,977.897,977.276,977.655,976.138,976.069,979.172,978.931,979.793,980.897,981.552,980.828,981.897,982.345,985.966,984.793,983.207,981.655,976.276,973.621,975.379,964.724,963.069,964.828,965.207,965.138,962.793,962.034,963.655,962.552,964.655,965.207,966.069,965.966,965.897,965.862,965.862,966.241,966.241,965.793,966.276,966.414,968.103,967.379,968.069,970.379,969.31,966.207,967.172,965.034,974.69,972.828,971.31,972.931,966,976.172,976.103,976.241,976.172,973.828,972.345,971.759,971.966,971.552,970.69,970.621,967.931,967.448,965.517,965.517,965.379,965.207,965.207,965.241,964.862,967.31,975.621,975.241,972.379,972.276,975.862,977.552,975.69,983.552,983.621,983.655,983.517,981.862,983.621,985.069,980.103,980.172,977.276,977.207,973.379,975.793,975.724,978.241,977.379,977.828,977.931,977.724,976.69,977.276,977.241,976.448,974.138,977.414,977.552,977.414,977.552,977.483,977.483,977.448,977.31,977.276,977.931,978.759,978.759,984.241,967.034,970.483,969.828,972.897,973.828,974.897,974.483,973.414,967.172,966.897,967.345,969.172,968.552,960.69,961.517,965.862,965.862,965.759,965.793,965.69,965.69,965.69,965.69,965.828,965.414,966.931,966.655,966.793,966.862,983.793,983.517,984.379,985.897,967.69,966.138,966.31,967.966,972.448,972.759,971.172,971.138,957.69,957.345,956.069,955.931,952.414,952.448,952.448,952.414,952.448,952.483,952.483,952.483,952.931,950.655,949.172,952.414,949.069,950.207,951.172,950.414,939.931,955.517,956.931,956.172,956.517,957.724,957.31,938.586,907.847,888.377]
Loading 
---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Operations" 67 --> 105
    line [76.264,79.651,83.207,83.172,79.759,79.759,79.759,79.759,79.724,79.759,79.759,79.759,82.897,82.897,82.931,86.345,86.517,86.517,86.517,86.517,89.931,91.897,92,92.379,92.483,93.241,93.172,93.276,93.31,91.034,91.103,91.207,91.241,94.655,94.655,94.655,91.276,91.345,91.31,91.31,91.31,91.31,91.31,91.276,91.31,91.138,87.724,87.724,87.724,87.724,87.69,87.724,87.724,87.621,87.31,87.103,86.69,86.655,87.172,86.483,86.517,86.517,86.552,86.552,86.621,87.276,86.862,87.138,86.655,86.655,86.655,86.69,86.724,86.69,90.103,93.517,93.448,93.414,93.379,93.414,93.379,93.379,91.931,92.276,92.483,92.897,92.931,94.621,95.207,93.931,90.483,90.552,90.552,90.483,93.207,93.586,93.276,90.345,88.931,88.517,88.724,87,87,87,87,87.069,86.897,86.862,86.897,85.828,83.862,85.414,85.414,85.414,85.345,81.931,78.724,78.586,79.862,83.207,83.103,83.103,83.103,83.103,80.552,79.793,83.207,84.621,85.034,84.793,86.517,86.517,86.552,83.138,83.172,83.379,83.448,83.448,81.103,79.655,79.655,79.621,79.621,79.69,83.103,86.31,86.448,86.414,86.517,83.138,79.724,79.724,79.724,82.276,83.069,83.069,83.069,83.069,83.034,79.69,79.724,79.69,83.103,83.069,82.414,82.172,82.103,83.138,86.552,86.552,86.552,86.552,86.552,85.483,83.276,82.138,81.655,81.759,84.621,87.414,86.724,86.793,86.793,84.793,84.586,84.552,84.103,83.517,86.862,86.793,85.931,86.069,85.483,85.724,84.414,84.483,86.897,86.897,86.897,86.931,83.517,83.276,84.241,86.172,86.828,86.241,84.966,85.483,86.138,86.793,86.552,85.414,85.414,85.552,85.586,82.621,79.828,79.828,79.862,80.724,80.586,81.172,81.586,83.103,79.69,79.655,79.655,79.655,79.621,83.034,83.276,83.379,80.276,80.759,81.828,83,83,82.966,83,79.828,80.897,79.517,79.586,79.586,83,86.379,82.966,82.966,82.966,82.966,82.966,82.966,83,86.379,86.379,83.103,83.138,83.138,83.138,83.138,83.138,86.517,86.517,84.414,84.69,83.241,83.241,83.241,86.586,86.655,90.034,88,86.759,84.517,84.621,86.862,83.448,83.448,83.448,83.448,83.448,83.448,80.103,80.034,79.931,79.897,79.897,79.897,79.897,79.897,79.897,76.517,75.207,74.931,76.379,76.379,76.379,76.379,76.379,76.379,78.414,79.69,81.897,81.897,83.069,86.483,86.448,86.276,86.276,86.138,83.305,86.414,86.517,86.483,86.483,86.483,86.483,86.483,86.483,86.483,89.862,93.276,93.276,93.276,93.276,90,90.034,90.034,90.034,90.034,89.379,86.69,86.552,86.621,86.621,86.655,86.828,85.414,83.586,86.385,86.69,86.655,90.069,90.069,86.69,86.724,86.724,86.724,86.724,86.724,86.724,86.724,86.724,86.724,90,89.966,89.966,89.793,88.276,87.31,90.034,90.103,90.103,90.103,86.724,86.724,88.138,90.103,90.138,90.069,86.724,86.655,83.276,86.655,86.621,86.621,86.621,86.621,86.621,86.621,86.621,83.276,83.276,83.276,83.276,83.276,83.448,84.966,83.207,83.207,83.207,83.138,83.138,86.517,86.517,85.69,83.138,79.724,79.724,83.069,83.138,86.517,86.517,86.517,83.138,83.172,83.172,83.172,83.172,83.172,86.517,83.172,83.103,79.724,79.724,79.724,79.724,83.069,83.069,79.724,79.69,77.862,77.552,76.759,77.172,79.69,83.138,83.172,83.207,83.207,83.207,83.172,83.103,84.069,84.069,84.103,83.69,83.207,83.207,83.207,86.586,83.241,86.621,86.621,86.621,86.034,83.276,83.207,86.621,86.655,88.483,88.31,87.724,86.655,86.621,83.207,83.172,83.138,83.138,83.138,83.172,83.241,85.655,85.621,85.586,86,83.138,83.069,79.69,79.655,83.069,82.862,81.862,79.793,80.31,83.069,79.724,79.241,79,78.862,79.172,80.414,82.138,81.241,84.862,84.862,84.621,83.793,83.862,83.414,83.517,83.552,83.379,83.241,83.172,86.483,86.621,90,90,89.586,89.828,90.552,92.793,92.207,92.172,93.414,93.759,94.034,90.759,90.931,91.069,90.828,91.793,91.552,88.172,88.448,89.276,89.207,89.655,89.552,89.517,89.69,89.828,89.897,89.931,89.862,89.862,89.862,89.552,86.862,87.034,86.69,87.069,86.897,88.517,86.586,86.483,89.966,89.966,90,90,86.586,86.586,89.966,89.931,89.931,89.931,89.931,89.931,86.655,86.655,86.655,86.655,86.655,86.655,86.655,83.31,84.034,86.69,86.793,86.966,87.241,87.448,88,90,90.069,90,86.724,83.276,83.276,86.69,86.69,86.69,86.69,83.659,80.307]
Loading

95th Percentile Latency

---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=read"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 8 --> 16
    line [10.927,11.229,11.122,10.869,10.598,10.241,9.985,9.93,9.903,9.868,9.783,9.788,9.801,9.783,9.837,9.911,9.918,9.894,9.907,9.965,9.956,9.992,9.962,9.96,9.943,9.919,9.908,9.87,9.84,9.83,9.818,9.874,9.89,9.946,9.981,10,10.081,10.428,10.753,11.278,11.073,11.205,11.334,11.248,11.06,11.157,11.23,11.561,11.482,11.788,11.823,12.034,11.959,12.244,12.416,12.381,12.399,12.316,12.278,12.354,12.169,12.307,12.183,12.071,11.973,11.934,11.868,11.878,11.579,11.622,11.57,11.475,11.379,11.345,11.417,11.449,11.139,11.095,10.811,10.603,10.497,10.542,10.095,10.104,9.992,9.975,10.096,9.979,9.917,9.918,9.893,9.911,9.973,10.445,10.966,11.198,11.224,11.169,11.303,11.497,11.727,11.956,12.283,12.447,12.602,12.786,12.789,12.883,12.882,13.088,13.301,13.381,13.435,13.539,13.627,13.588,13.749,13.992,14.052,14.037,14.131,14.076,13.949,13.876,13.724,13.814,13.941,13.934,13.864,13.765,13.881,13.834,13.857,13.735,13.796,13.843,13.948,14.004,13.884,13.81,13.987,13.905,14.025,14.027,14.091,14.076,13.92,13.988,13.967,13.827,13.874,13.905,13.869,13.942,13.906,13.85,13.825,13.743,13.813,13.506,13.446,13.194,13.166,12.754,12.473,12.131,12.08,11.874,11.852,11.597,11.528,11.143,11.299,11.133,10.932,10.762,10.667,10.784,10.912,10.86,10.917,11.022,11.077,10.709,10.755,10.794,10.817,10.72,10.899,10.762,10.997,11.036,11.25,11.503,11.635,11.588,11.709,11.614,11.444,11.303,11.159,10.982,11.03,11.128,11.119,10.926,10.635,10.393,10.386,10.237,10.14,10.164,10.244,10.117,9.962,9.932,9.896,9.924,9.956,9.959,9.993,10.056,10.533,10.359,10.205,10.143,10.484,10.694,10.96,11.271,11.303,11.141,10.924,10.881,10.825,10.654,10.563,10.495,10.669,10.506,10.287,10.202,10.494,10.636,10.827,10.819,10.454,10.132,10.159,10.138,10.25,9.928,9.94,9.953,9.95,9.871,9.85,9.813,9.785,9.77,9.764,9.845,9.891,9.882,9.919,9.924,9.938,9.905,9.907,9.937,9.979,9.919,9.935,9.881,9.879,9.868,9.84,9.803,9.769,9.749,9.819,9.827,9.821,9.829,9.802,9.758,9.739,9.697,9.646,9.676,9.611,9.52,9.495,9.542,9.62,9.659,9.688,9.74,9.708,9.679,9.718,9.706,9.811,9.857,9.916,9.96,9.979,9.994,10.075,9.989,9.96,9.995,9.987,10.155,10.152,10.201,10.469,10.761,10.745,10.674,10.851,11.029,10.962,10.814,10.701,10.465,10.363,10.334,10.422,10.354,10.286,9.975,9.93,9.904,9.896,9.875,9.834,9.785,9.744,9.802,9.793,9.811,9.799,9.813,9.785,9.761,9.723,9.691,9.715,9.739,9.767,9.807,9.844,9.885,9.948,9.972,9.985,9.985,9.976,9.99,9.97,9.954,9.937,9.952,9.944,9.945,9.963,9.966,9.952,9.969,9.948,10,9.976,10.288,10.328,10.307,10.409,10.22,9.985,9.957,9.872,9.828,9.805,9.823,9.807,9.821,9.828,9.823,9.779,9.849,9.889,9.926,9.935,9.996,10.282,10.078,9.994,9.972,9.934,9.931,9.878,9.964,9.961,10.203,10.11,9.975,9.97,10.077,10.28,10.515,10.359,10.058,9.948,9.932,9.932,9.938,9.97,10.202,9.992,9.955,9.945,9.898,9.824,9.772,9.764,9.765,9.753,9.77,9.779,9.81,9.795,9.821,9.8,9.832,9.909,9.943,9.945,9.949,9.946,9.982,9.992,9.973,9.948,9.91,9.923,9.906,9.875,9.877,9.929,9.947,9.995,10.462,10.513,10.868,10.814,10.652,10.287,10.287,10.032,9.963,9.908,9.851,9.832,9.809,9.769,9.78,9.743,9.743,9.691,9.728,9.765,9.79,9.783,9.731,9.718,9.765,9.755,9.768,9.779,9.8,9.782,9.82,9.823,9.853,9.876,9.902,9.908,9.91,9.906,9.896,9.872,9.868,9.873,9.937,9.91,9.917,9.929,9.968,9.948,9.925,9.889,9.886,9.889,9.904,9.844,9.862,9.876,9.811,9.736,9.71,9.695,9.682,9.668,9.667,9.707,9.728,9.741,9.758,9.789,9.858,9.941,9.932,9.921,9.928,9.98,9.957,9.963,9.964,9.946,9.927,9.925,9.923,9.913,9.917,9.898,9.813,9.802,9.863,9.883,9.873,9.852,9.843,9.897,9.889,9.889,9.877,9.86,9.879,9.87,9.769,9.738,9.651,9.577,9.481,9.471,9.498,9.434,9.502,9.575,9.584,9.569,9.56,9.611,9.623,9.686,9.73,9.722,9.691,9.657,9.705,9.745,9.744,9.778,9.769,9.791,9.812]
Loading 
---
config:
    xyChart:
        width: 1200
        height: 400
    themeVariables:
        xyChart:
            titleColor: "#222"
            backgroundColor: "#fff"
            xAxisLineColor: "#222"
            yAxisLineColor: "#222"
            plotColorPalette: "#FF7F0E,#1F77B4,#D62728,#2CA02C,#9467BD,#8C564B,#E377C2,#7F7F7F,#BCBD22,#17BECF"
---
xychart-beta
    title "operation_type=write"
    x-axis "Time, m" 0 --> 10
    y-axis "Latency, ms" 13 --> 22
    line [17.094,17.29,17.193,17.049,17.08,17.004,16.857,16.678,16.549,16.469,16.335,16.147,16.014,15.629,15.806,15.952,15.943,15.785,15.838,16.162,16.074,16.246,16.075,16.173,16.104,15.888,15.809,15.794,15.73,15.466,15.7,15.895,16.149,16.151,16.238,16.497,16.646,16.932,17.095,17.46,17.46,17.651,17.735,17.695,17.602,17.608,17.691,17.835,17.759,17.9,17.834,17.859,17.797,17.879,17.992,17.99,17.963,17.9,17.901,17.776,17.744,17.744,17.774,17.774,17.659,17.694,17.692,17.746,17.565,17.6,17.528,17.517,17.541,17.553,17.599,17.555,17.495,17.511,17.421,17.283,17.254,17.266,17.146,17.081,16.95,16.83,16.935,16.861,16.648,16.636,16.589,16.621,16.791,17.047,17.072,17.031,16.853,16.824,16.938,17.019,17.173,17.143,17.322,17.341,17.421,17.506,17.308,17.215,17.2,17.364,17.63,17.662,17.774,17.803,17.856,17.89,17.988,18.153,18.138,18.09,18.169,18.141,18.05,18.065,18.066,18.168,18.159,18.086,18.049,17.944,18.131,18.052,18.027,18.031,18.009,18.126,18.211,18.208,18.2,18.075,18.202,18.064,18.202,18.185,18.131,18.063,17.936,18.041,18.069,17.955,17.983,18.194,18.261,18.35,18.428,18.466,18.527,18.586,18.732,18.645,18.664,18.636,18.573,18.478,18.507,18.499,18.668,18.647,18.706,18.705,18.837,18.797,18.93,19.03,19.082,19.133,19.193,19.199,19.189,19.198,19.195,19.221,19.218,19.237,19.347,19.367,19.367,19.374,19.412,19.435,19.49,19.503,19.516,19.528,19.56,19.488,19.474,19.46,19.426,19.351,19.356,19.352,19.325,19.314,19.355,19.344,19.366,19.377,19.36,19.311,19.286,19.324,19.306,19.225,19.176,19.153,19.117,19.079,19.111,19.075,19.186,19.228,19.226,19.203,19.259,19.229,19.251,19.296,19.359,19.393,19.391,19.388,19.405,19.372,19.336,19.297,19.247,19.201,19.206,19.189,19.074,19.055,19.117,19.117,19.119,19.081,19.054,18.943,18.938,18.831,18.8,18.747,18.705,18.681,18.799,18.752,18.771,18.655,18.558,18.49,18.397,18.493,18.558,18.595,18.708,18.812,18.897,18.946,18.977,19.059,19.076,19.027,19.065,19.061,19.089,19.049,19.11,19.099,19.081,19.111,19.185,19.215,19.239,19.233,19.235,19.206,19.202,19.15,19.081,19.126,19.08,19.04,19.027,19.043,19.052,19.062,19.017,18.988,18.971,18.913,18.907,18.817,18.881,18.902,19.011,19.025,19.092,19.123,19.095,19.033,19.02,19.111,19.078,19.078,19.042,19.025,19.095,19.134,19.132,19.157,19.151,19.097,19.042,19.001,18.969,18.985,19.013,19.044,19.088,19.103,19.162,19.139,19.077,18.957,18.868,18.718,18.58,18.494,18.459,18.567,18.452,18.478,18.447,18.423,18.505,18.459,18.426,18.355,18.434,18.469,18.622,18.741,18.841,18.903,18.909,18.931,18.88,18.856,18.805,18.838,18.753,18.756,18.756,18.756,18.824,18.824,18.804,18.766,18.754,18.767,18.755,18.842,18.907,19.008,19.023,19.005,19.009,18.928,18.862,18.826,18.732,18.636,18.635,18.74,18.693,18.78,18.829,18.819,18.756,18.914,19.044,19.152,19.223,19.239,19.284,19.293,19.316,19.283,19.221,19.165,19.08,19.113,19.04,19.057,19.092,19.065,19.034,19.101,19.125,19.135,19.069,19.048,18.908,18.881,18.863,18.917,18.935,18.963,18.886,18.815,18.776,18.693,18.529,18.417,18.405,18.329,18.283,18.435,18.512,18.611,18.582,18.536,18.609,18.624,18.806,18.898,18.944,18.97,18.982,19.075,19.014,19.054,19.021,18.943,18.901,18.904,18.876,18.835,18.899,18.884,18.938,19.105,19.131,19.192,19.209,19.247,19.186,19.145,19.083,18.999,18.932,18.763,18.673,18.475,18.338,18.326,18.187,18.193,18.061,18.299,18.424,18.644,18.685,18.566,18.44,18.549,18.604,18.654,18.739,18.774,18.648,18.739,18.742,18.797,18.747,18.769,18.825,18.86,18.885,18.914,18.913,18.912,19.013,19.145,19.065,19.045,19.077,19.064,19.025,18.963,18.81,18.806,18.783,18.849,18.736,18.721,18.636,18.476,18.388,18.384,18.354,18.402,18.365,18.32,18.377,18.466,18.53,18.579,18.666,18.852,18.93,18.864,18.846,18.87,18.933,18.863,18.864,18.946,18.931,18.955,18.941,18.997,18.97,18.996,18.987,18.956,18.958,19.007,18.983,18.91,18.804,18.829,18.979,18.988,18.978,18.958,18.904,18.939,18.916,18.905,18.883,18.75,18.67,18.528,18.432,18.523,18.396,18.54,18.603,18.624,18.55,18.57,18.598,18.588,18.627,18.668,18.601,18.592,18.653,18.753,18.757,18.74,18.737,18.723,18.743,18.816]
Loading

vgvoleg
vgvoleg requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@vgvoleg vgvoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Can you please add a test?

@MBogda MBogda force-pushed the fix-cancel-during-session-pool-wait branch from cacb4ea to cf5f474 Compare December 23, 2024 21:47
@MBogda
Copy link
Contributor Author

MBogda commented Dec 23, 2024 •
edited
Loading

Hi! Can you please add a test?

Hi! I've modified existing test test_no_race_after_future_cancel so that it fails without changes and passes with them.

UPD: modified again, now it's clear why test didn't work:

  1. Waiter didn't manage to start.
  2. Waiter cancellation hadn't been completed at the time of the check.

@MBogda MBogda force-pushed the fix-cancel-during-session-pool-wait branch 2 times, most recently from aa81376 to 96e8edd Compare December 23, 2024 22:47
@MBogda
Copy link
Contributor Author

MBogda commented Dec 27, 2024

@vgvoleg hi! Can you please review it?

makhalin
makhalin reviewed Jan 8, 2025
View reviewed changes
ydb/aio/table.py Outdated Show resolved Hide resolved
@MBogda MBogda force-pushed the fix-cancel-during-session-pool-wait branch from 96e8edd to 1d29f44 Compare January 8, 2025 17:18
rekby
rekby reviewed Jan 9, 2025
View reviewed changes
tests/aio/test_session_pool.py Outdated
s = await pool.acquire()
waiter = asyncio.ensure_future(pool.acquire())
await asyncio.sleep(0.001)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the PR. I have a question:

Why do you need wait a millisecond?
what about sleep(0) - for wait one loop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right! sleep(0) will work here as we need only one switch. I added a millisecond just in case, but seems that it's useless.

I've checked on my machine and with sleep(0) it works as expected — fails without new changes and passes with them.

Copy link
Contributor Author

@MBogda MBogda Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rekby hi! Could you check new version please? Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vgvoleg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vgvoleg hi again, could you check the new version please? Thanks!

@MBogda MBogda force-pushed the fix-cancel-during-session-pool-wait branch 2 times, most recently from 6eef899 to 73a492c Compare January 9, 2025 11:27
@MBogda MBogda force-pushed the fix-cancel-during-session-pool-wait branch from 73a492c to 60a4d87 Compare January 9, 2025 11:54
@vgvoleg vgvoleg merged commit 1f2c466 into ydb-platform:main Jan 13, 2025
10 checks passed
@MBogda MBogda deleted the fix-cancel-during-session-pool-wait branch January 13, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makhalin makhalin makhalin left review comments

@rekby rekby rekby left review comments

@vgvoleg vgvoleg vgvoleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MBogda @makhalin @rekby @vgvoleg