feat: add backward compatibility for setDefaultLogger

ydb-platform · Mar 7, 2023 · bd637bc · bd637bc
1 parent affbbc2
commit bd637bc
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/examples/custom-logger/dummy.ts b/examples/custom-logger/dummy.ts
@@ -1,5 +1,5 @@
 import {main} from '../utils';
-import {Logger, LogFn, Driver, getCredentialsFromEnv, setupLogger} from 'ydb-sdk';
+import {Logger, LogFn, Driver, getCredentialsFromEnv, setupLogger, setDefaultLogger} from 'ydb-sdk';
 
 const logFunction: LogFn = (obj: any, ...args: any[]) => {
     console.log('Custom logging!', obj, ...args);
@@ -14,7 +14,8 @@ const MyLogger: Logger = {
 };
 
 export async function run(logger: Logger, endpoint: string, database: string) {
-    await setupLogger(MyLogger);
+    setupLogger(MyLogger);
+    // setDefaultLogger(MyLogger); // will work too
     logger.info('Driver initializing...');
     const authService = getCredentialsFromEnv();
     const driver = new Driver({endpoint, database, authService});

diff --git a/src/index.ts b/src/index.ts
@@ -2,6 +2,7 @@ export {Ydb} from 'ydb-sdk-proto';
 export {
     getLogger,
     setupLogger,
+    setDefaultLogger,
     Logger,
     LogFn,
     FallbackLogger,

diff --git a/src/logging.ts b/src/logging.ts
@@ -28,6 +28,13 @@ export function setupLogger(logger: Logger) {
     globalLogger = logger;
     globalLogger.debug(`Default logger changed to ${globalLogger.constructor.name}`);
 }
+/**
+ * @deprecated
+ * Use setupLogger instead
+ */
+export function setDefaultLogger(logger: Logger){
+    return setupLogger(logger)
+}
 
 /** basic fallback implementation of LogFn */
 export function getFallbackLogFunction(level: string) {
@@ -85,7 +92,7 @@ export class FallbackLogger implements Logger {
 export function getLogger(options?: any): Logger {
     if (!globalLogger) {
         globalLogger = new FallbackLogger(options);
-        globalLogger.warn('Using fallback logger');
+        globalLogger.debug('Using fallback logger');
     }
     return globalLogger;
 }