Enable 3 node deployment #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorres
force-pushed
the
enable-3-node-deployment
branch
from
b1885ed to
b211a27
Compare
Jorres
force-pushed
the
enable-3-node-deployment
branch
from
b211a27 to
c1f9b14
Compare
|
Cancelled tests are okay! The ones triggered by 'pull request' are the same as the one triggered by 'pull_request_target'. After this merges, the 'pull_request_target' will no longer exist and only one set of jobs, without For the proof that an outside person can not run the workflow without approval, see this closed PR, which I opened from another account, not belonging to YDB Platform: #250 |
kobzonega
reviewed
Sep 30, 2024
kobzonega
reviewed
Sep 30, 2024
kobzonega
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Other information
Migrating from 8-node YDB cluster with block-4-2 erasure to 3-node YDB cluster with mirror-3-dc erasure allowed us to run tests on top of Github runners, eliminating the need to supply secrets and a huge chunk of workflow YAML code.
Todo @Jorres: after this merges, remove unnecessary secrets from this repo