feat: vdisks in 2 rows #1758
feat: vdisks in 2 rows #1758
Conversation
src/mocks/storage/nodes.ts
Outdated
| @@ -0,0 +1,158 @@ | |||
| import {EFlag} from '../../types/api/enums'; | |||
There was a problem hiding this comment.
for test only (will delete before merge)
| flex-shrink: 0; | ||
| flex: 0 0 3px; | ||
|
|
||
| min-width: 3px; |
There was a problem hiding this comment.
Your solution works well only in the case, where all pdisks have the same amount of vdisks, it's not always true.
Previously we assumed, that all pdisks should be of the same size, so MaximumSlotsPerDisk was introduced so it will be possible to calculate pdisk size for paginated table (something like pDiskSize = MaximumSlotsPerDisk * VDISK_SIZE) and use it for all pdisks in this table (even if the don't have any vdisks)
There was a problem hiding this comment.
fixed
Also added random vdisks count generation to pdisks in mocks
| const maximumSlots = calculateMaximumSlotsPerDisk(Nodes, MaximumSlotsPerDisk); | ||
| const preparedNodes = Nodes?.map((node) => prepareStorageNodeData(node, maximumSlots)); |
There was a problem hiding this comment.
It looks like different table chunks could have different pdisk size with such calculations, since prepareStorageNodesResponse is called for every chunk
There was a problem hiding this comment.
It handles corner case of the scenario, which it a corner case by itself. Decided in pm to leave it as it is in PR
Closes #730
Stand
use parameters ( /cluster/storage?type=nodes&mocks=1&pdisks=10&vdisksPerPDisk=100 )
to play with markup
This PR is really only about changing two css files
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 65.88 MB | Main: 65.88 MB
Diff: +2.68 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information