feat: remove unused exports, functions and files #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
remove-unused
branch
from
b62bff4 to
2c871be
Compare
artemmufazalov
commented
Dec 12, 2024
| @@ -69,7 +69,7 @@ | |||
| "lint:styles": "stylelint 'src/**/*.{css,scss}'", | |||
| "lint:other": "npm run prettier -- --check", | |||
| "prettier": "prettier '**/*.{json,yaml,yml,md}'", | |||
| "unimported": "npx unimported --no-cache", | |||
| "unused": "npx knip --include dependencies,files,exports,types", | |||
There was a problem hiding this comment.
unimported is marked as deprecated now in favor of knip. knip can search not only unused files and deps, but also unused exports. When unused export is deleted and function is not used locally, it will be marked by our linter
artemmufazalov
commented
Dec 12, 2024
| @@ -62,6 +63,7 @@ export function Operations({database}: OperationsProps) { | |||
| {data ? ( | |||
| <ResizeableDataTable | |||
| columns={getColumns({database, refreshTable: refetch})} | |||
| columnsWidthLSKey={OPERATIONS_SELECTED_COLUMNS_KEY} | |||
There was a problem hiding this comment.
This property was declared, but was not passed
artemmufazalov
commented
Dec 12, 2024
Comment on lines
+19
to
+22
| const b = cn('ydb-storage-nodes'); | ||
|
|
||
| const getRowUnavailableClassName = (row: PreparedStorageNode) => | ||
| b('node', {unavailable: isUnavailableNode(row)}); |
There was a problem hiding this comment.
Code from StorageNodes/shared.ts
artemmufazalov
commented
Dec 12, 2024
|
|
||
| import {StorageNodesEmptyDataMessage} from './StorageNodesEmptyDataMessage'; | ||
| import {STORAGE_NODES_COLUMNS_WIDTH_LS_KEY} from './columns/constants'; | ||
| import type {StorageNodesColumn} from './columns/types'; | ||
| import {getStorageNodes} from './getNodes'; | ||
| import i18n from './i18n'; | ||
| import {getRowUnavailableClassName} from './shared'; | ||
|
|
||
| import './StorageNodes.scss'; |
There was a problem hiding this comment.
File was not imported, so unavailable nodes weren't grey
artemmufazalov
commented
Dec 12, 2024
| @@ -15,7 +15,7 @@ const initialState: ITooltipState = { | |||
| toolTipVisible: false, | |||
| currentHoveredRef: undefined, | |||
| data: undefined, | |||
| templateType: 'pool', | |||
| templateType: 'cell', | |||
There was a problem hiding this comment.
Our redux tooltip requires some initial value to be set
Raubzeug
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib.ts- everything should be imported from there, when app is used as packageThere are still unused exports and files, I didn't delete everything
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔽
Current: 65.84 MB | Main: 65.86 MB
Diff: 0.01 MB (-0.02%)
✅ Bundle size decreased.
ℹ️ CI Information