feat(Network): add peer role filter #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Nov 29, 2024
| @@ -63,7 +63,7 @@ export const useViewerNodesHandlerHasGroupingBySystemState = () => { | |||
| }; | |||
|
|
|||
| export const useViewerNodesHandlerHasNetworkStats = () => { | |||
| return useGetFeatureVersion('/viewer/nodes') > 12; | |||
| return useGetFeatureVersion('/viewer/nodes') > 13; | |||
There was a problem hiding this comment.
Network table is now an experiment, there is no need to implement features inside the experiment with their own feature flags. Peer role filter was added in 14 version, so the whole experiment version will be 13+
Raubzeug
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1689
Stand: https://nda.ya.ru/t/jhLWCrm77A2kku
CI Results
Test Status: ✅ PASSED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 65.97 MB | Main: 65.96 MB
Diff: +6.06 KB (0.01%)
ℹ️ CI Information