issue-324: DescribeData: 1. BlobOffsets should be in bytes, not blocks 2. returning FileSize 3. added a ut that checks that we don't return data outside of the aligned superrange that contains the requested range #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s 2. returning FileSize 3. added a ut that checks that we don't return data outside of the aligned superrange that contains the requested range
debnatkh
approved these changes
Feb 9, 2024
|
Флапнули 2 теста ДМ |
yegorskii
approved these changes
Feb 10, 2024
qkrorlqr
added a commit
that referenced
this pull request
Feb 15, 2024
…s 2. returning FileSize 3. added a ut that checks that we don't return data outside of the aligned superrange that contains the requested range (#399)
qkrorlqr
added a commit
that referenced
this pull request
Feb 15, 2024
* issue-324: DescribeData: 1. BlobOffsets should be in bytes, not blocks 2. returning FileSize 3. added a ut that checks that we don't return data outside of the aligned superrange that contains the requested range (#399) * issue #324: storing NProto::TFileStore in session state to use it in the two stage read implementation in TServiceActor (#400) * issue #324: DescribeData: offset calculation shouldn't use TBlock::BlockIndex since this block might be not initialized (#402) * NBSNEBIUS-101: use vhost-side reads WIP. Issue: #95 (#394) * [Draft] NBSNEBIUS-101: use vhost-side reads * WIP: service_actor_readdata * add describe data test * add describe data test * add ut + fix readblob implementation * enable TwoStageReadEnabled feature-flag * fix ut + trigger large tests --------- Co-authored-by: Maxim Deb Natkh <debnatkh@yandex.ru> * issue-324: proper EvGet error handling, not outputting user data to logs, dependencies cleanup, code cleanup (#419) * issue-324: proper EvGet error handling, not outputting user data to logs, dependencies cleanup, code cleanup * issue-324: proper EvGet error handling, not outputting user data to logs, dependencies cleanup, code cleanup - forgot libs/storage/model/ut * issue-324: proper EvGet error handling, not outputting user data to logs, dependencies cleanup, code cleanup - forgot libs/storage/model/public.h * issue-324: proper EvGet error handling, not outputting user data to logs, dependencies cleanup, code cleanup - fixed event-log lib * issue-324: TServiceActor: ReadData fallback in case DescribeData or EvGet fail (#428) * issue-324: TServiceActor: ReadData fallback in case DescribeData or EvGet fail * issue-324: TServiceActor: ReadData fallback in case DescribeData or EvGet fail * issue-324: TServiceActor: ReadData fallback in case DescribeData or EvGet fail - discarding EvGetResults after switching to the ReadData fallback * issue-324: TServiceActor: ReadData fallback in case DescribeData or EvGet fail - cleanup * issue-324: added ut and loadtest for the TwoStageRead feature, fixed a crash in TReadDataActor::HandleReadBlobResponse (#441) * issue-324: added ut and loadtest for the TwoStageRead feature, fixed a crash in TReadDataActor::HandleReadBlobResponse * issue-324: added ut and loadtest for the TwoStageRead feature, fixed a crash in TReadDataActor::HandleReadBlobResponse - forgot nfs-storage.txt * updated CMakeLists after cherry-pick * updated CMakeLists after cherry-pick - forgot to add new CMakeLists * contrib/ydb -> ydb * contrib/ydb -> ydb --------- Co-authored-by: Maxim Deb Natkh <debnatkh@gmail.com> Co-authored-by: Maxim Deb Natkh <debnatkh@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes and improvements for DescribeData