issue-757: should not unmount volume (in local-emergency test) before static BS group destruction in order to make emergency unexpected #2079
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… static BS group destruction in order to make emergency unexpected
SvartMetal
commented
Sep 19, 2024
| data = session.read_blocks(100499, 3, "") | ||
| # check data (that was written) together with left & right neighborhood | ||
| assert data == [b''] + [b'\1' * 4096] + [b''] | ||
| # TODO: should not unmount volume to make emergency unexpected | ||
| session.unmount_volume() |
There was a problem hiding this comment.
этот unmount здесь нужен, так как мы хотим проверить два сценария:
- монтирование диска -> катастрофа -> чтение (из той же сессии) - тем самым убеждаемся что диск не размонтировался из-за катастрофы
- катастрофа -> отмонтирование диска и монтирование его заново (в ходе теста) - тем самым убеждаемся что диск можно отмонтировать и снова смонтировать
SvartMetal
commented
Sep 19, 2024
| @@ -116,11 +114,9 @@ def __run_test(test_case): | |||
| env.nbs.storage_config_patches = [storage_config_with_emergency_mode(backups_folder)] | |||
| env.nbs.restart() | |||
|
|
|||
| session.mount_volume() | |||
There was a problem hiding this comment.
теоретически тест может упасть с invalid session, если nbs/kikimr долго рестартует
проверю локально, поставив прогон в цикле на ночь
qkrorlqr
approved these changes
Sep 19, 2024
SvartMetal
added
blockstore
BarkovBG
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#757