Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filestore] avoid fsync on every write for local service #1990

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Filestore] avoid fsync on every write for local service #1990

wants to merge 3 commits into from

Conversation

budevg
Copy link
Collaborator

@budevg budevg commented Sep 10, 2024 •
edited
Loading

Rely on user-invoked fsync for data consistency in local filestore instead of implicitly calling it after each write.

@budevg budevg changed the title users/evgenybud/filestore local fsync NBSNEBIUS-371: avoid fsync on every write for local service Sep 10, 2024
@budevg budevg added the filestore Add this label to run only cloud/filestore build and tests on PR label Sep 10, 2024
@budevg budevg changed the title NBSNEBIUS-371: avoid fsync on every write for local service [Filestore] avoid fsync on every write for local service Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit f89399b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1815 1790 0 25 0 0

@budevg
NBSNEBIUS-371: avoid fsync on every write for local service
8059129 
Rely on user-invoked fsync for data consistency instead of implicitly calling it
after each write.
@budevg budevg force-pushed the users/evgenybud/filestore-local-fsync branch from f89399b to 8059129 Compare September 12, 2024 10:12
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 8059129.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1815 1815 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6f76645.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1815 1815 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkrorlqr qkrorlqr qkrorlqr left review comments

@yegorskii yegorskii Awaiting requested review from yegorskii

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
filestore Add this label to run only cloud/filestore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@budevg @qkrorlqr