Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-1657: resize pvc with nbd-lightweight and minikube #1846

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

issue-1657: resize pvc with nbd-lightweight and minikube #1846

wants to merge 5 commits into from
+136 −34

Conversation

antonmyagkov
Copy link
Collaborator

@antonmyagkov antonmyagkov commented Aug 22, 2024 •
edited
Loading

issue: #1657

Support pvc resize with minikube/nbd-lightweight

  1. Update minikube manifests:
  • Add csi-resizer sidecar to csi controller
  • Allow to expand volume
  • Increase pvc storage limit as it is not possible to expand volume beyond the limit
  1. Fix volume resize in nbd-lightweight. Old blocks count value was cached in several places: mounted volume, storage and storage adapter. Fixed by recreating storage/storage adapter.

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from f0f65ea to d81b727 Compare August 22, 2024 18:04
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d81b727.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5687 5684 0 0 1 2

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from d81b727 to 177bf05 Compare September 14, 2024 09:16
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 177bf05.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5772 5771 0 1 0 0

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 177bf05 to 6a03597 Compare September 16, 2024 08:06
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 6a03597.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5773 5769 0 0 2 2

@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 6a03597 to 75def04 Compare September 16, 2024 12:46
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 75def04.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5772 5769 0 0 1 2

@antonmyagkov antonmyagkov changed the title issue-1657: add csi-resizer to minikube manifests issue-1657: resize pvc with nbd-lightweight and minikube Sep 16, 2024
@antonmyagkov antonmyagkov force-pushed the users/myagkov/issue-1657-csi-resizer branch from 75def04 to 9d7025a Compare September 17, 2024 15:32
@antonmyagkov antonmyagkov added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Sep 17, 2024
qkrorlqr
qkrorlqr reviewed Sep 17, 2024
View reviewed changes
cloud/blockstore/libs/service_local/service_local.cpp Outdated Show resolved Hide resolved
cloud/blockstore/libs/service_local/service_local.cpp
blockSize,
true)
, StorageAdapter(std::make_unique<TStorageAdapter>(
std::move(storage),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а тут какие-то 2 лишних пробела добавилось в отступ

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Потому что теперь это параметры std::make_unique

cloud/blockstore/libs/service_local/service_local.cpp Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 9d7025a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3274 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c43a693.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3274 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit b49ed6a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3274 3274 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkrorlqr qkrorlqr qkrorlqr approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonmyagkov @qkrorlqr