issue-1161: not initializing most of the per-filesystem request counters until we actually receive at least 1 request of the type #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers until we actually receive at least 1 request of the type
yegorskii
approved these changes
Aug 3, 2024
WilyTiger
approved these changes
Aug 3, 2024
qkrorlqr
added a commit
that referenced
this pull request
Aug 10, 2024
…ers until we actually receive at least 1 request of the type (#1711)
qkrorlqr
added a commit
that referenced
this pull request
Aug 11, 2024
…n local service; lazy filestore counters init; support for large unaligned writes in ThreeStageWrite mode (#1770) * issue-1668: TLocalFileSystem::ReadDataAsync/WriteDataAsync (#1686) * issue-1668: preparing to make TLocalFileSystem::ReadData/ReadData async * issue-1668: preparing to make TLocalFileSystem::ReadData/ReadData async - fix * issue-1668: fixed LocalService double start, fixed missing xattr error code * issue-1668: LocalService now uses TFileHandle instead of TFile; LocalService now uses libaio instead of synchronous pread/pwrite for ReadData/WriteData calls; added move assignment operator to TFileHandle * issue-1668: fixed LocalService ut * issue-1350: GetNodeAttrBatchEnabled: true for multitablet filestore tests (#1706) * issue-1161: not generating deletion markers upon symlink removal (#1707) * issue-1161: not initializing most of the per-filesystem request counters until we actually receive at least 1 request of the type (#1711) * issue-1161: fixed stupid lazy counter init race (#1722) * issue-1673: Unaligned requests support in ThreeStageWrite pipeline - IndexTablet part (#1740) * issue-1673: UnalignedDataParts support in TIndexTabletActor::AddData, TODO: uts * issue-1673: AddData now properly handles outdated UnalignedDataParts * issue-1673: AddData + UnalignedDataParts ut * issue-1673: AddData + UnalignedDataParts: using CommitId, generated in AddBlobTx (since the same CommitId is used for the blobs), adding some checks (#1754) * issue-1673: AddData + UnalignedDataParts: using CommitId, generated in AddBlobTx (since the same CommitId is used for the blobs), adding some checks * issue-1673: AddData + UnalignedDataParts: better error processing and logging, fixed ut * issue-1673: supported ThreeStageWrites for large unaligned requests in StorageServiceActor (#1769) * issue-1673: supported ThreeStageWrites for large unaligned requests in StorageServiceActor * issue-1673: supported ThreeStageWrites for large unaligned requests in StorageServiceActor - fixed logging * updated CMakeLists after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike NBS we have a lot of different request types in Filestore. And we report a lot of metrics for each <requestType, fsId> pair which generates a lot of work for the monitoring systems that we use. Most of the filesystems never receive the majority of these request types. In this PR I'm not reporting any per-FS counters except Count and Errors/Fatal for the request types which have never been seen by this FS. It should radically decrease the total number of metrics that we report (we'll get rid of a lot of unnecessarily reported zeroes).
#1161