Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates NEWS; adds test for 240 #246

Merged
merged 1 commit into from
Aug 19, 2021
Merged

updates NEWS; adds test for 240 #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
* add option to save as read only recommended ([#201](https://github.com/ychps/openxlsx/issues/201))
* fixed writing hyperlink formulas ([#200](https://github.com/ychps/openxlsx/issues/200))
* `write.xlsx()` now throws an error if it doesn't have write permissions ([#190](https://github.com/ycphs/openxlsx/issues/190))
* `Workbook$show()` no longer fails when called in a 0 sheet workbook([#240](https://github.com/ychps/openxlsx/issues/240))
* `read.xlsx()` again accepts `.xlsm` files ([#205](https://github.com/ychps/openxlsx/issues/205), [#209](https://github.com/ychps/openxlsx/issues/209))


# openxlsx 4.2.4

Expand Down
5 changes: 5 additions & 0 deletions tests/testthat/test-Workbook_properties.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,8 @@ test_that("Workbook properties", {
setLastModifiedBy(wb, "Philipp 2")
expect_true(grepl("<cp:lastModifiedBy>Philipp 2</cp:lastModifiedBy>", wb$core))
})


test_that("Workbook can print with 0 sheets [240]", {
expect_error(createWorkbook()$show(), NA)
})