-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement inlineStr
. closes #112 #161
#225
Conversation
…fore replace this mess with the nicer and working implementation from loadWorkbook.cpp
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
+ Coverage 65.44% 65.59% +0.15%
==========================================
Files 34 34
Lines 8879 8918 +39
==========================================
+ Hits 5811 5850 +39
Misses 3068 3068
Continue to review full report at Codecov.
|
Oh I'm not sure about the changes in |
…|' [-Wparentheses]
what does it do
This PR implements basic handling of
inlineStr
. It reads theinlineStr
<is>
node and handles it as if its a<v>
node witht="str"
. So this:is for our import logic identical to this
how was it implemented
I've implemented it as type
5
so once it's imported asinlineStr
it can be written asinlineStr
. My initial PR was quite small, only a few lines, but when testing it, reading withread.xlsx()
directly from files was slow as hell. Most likely due to hundreds of runs through the same large string. Therefore I had to remove the import logic from thegetCellInfo()
file and replace it with the logic fromloadworksheets()
. In theory there shouldn't be a measurable speed difference and this should be beneficial since it reduces the two different approaches for the same thing to only a single (duplicated) approach. Still I didn't run any benchmarks with previous versions against this PR.what's left for others to do
I haven't implemented any modifications for userspace functions to create, remove or modify
inlineStr
and I have no interest to do so. Therefore currently the only way to writeinlineStr
s withopenxlsx
is to import one, but I assume it can be implemented quite easily and might be beneficial for other reasons.final words?
Included in this PR are minor updates caused by a new Rcpp release (completely harmless) and a modification to the LICENSE file which was outdated.