Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #183 #224

Merged
merged 1 commit into from
Jul 11, 2021
Merged

resolves #183 #224

merged 1 commit into from
Jul 11, 2021

Conversation

jmbarbone
Copy link
Contributor

  • creates a temporary directory without changing random seed
  • adds testing

* creates a temporary directory without changing random seed
* adds testing
@codecov-commenter
Copy link

Codecov Report

Merging #224 (6abdeeb) into master (57333c1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   65.44%   65.44%   -0.01%     
==========================================
  Files          34       34              
  Lines        8879     8878       -1     
==========================================
- Hits         5811     5810       -1     
  Misses       3068     3068              
Impacted Files Coverage Δ
R/readWorkbook.R 87.63% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ce583...6abdeeb. Read the comment docs.

@ycphs ycphs merged commit a4f9b83 into ycphs:master Jul 11, 2021
jmbarbone added a commit to jmbarbone/openxlsx that referenced this pull request Jul 12, 2021
ycphs added a commit that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants