Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump remark dependencies and support ESM only #23

Merged
merged 3 commits into from
Aug 15, 2021

Conversation

ybiquitous
Copy link
Owner

@ybiquitous ybiquitous commented Aug 14, 2021

remark@14.0.0 supports only ESM.

@ybiquitous
Copy link
Owner Author

ybiquitous commented Aug 14, 2021

https://github.com/ybiquitous/remark-preset-ybiquitous/pull/23/checks?check_run_id=3328187750#step:6:26

remark-gfm seems to have a problem... 🤔

README.md
  1:1  error  TypeError: Cannot read property '2' of undefined
    at lineStart (file:///Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark-extension-gfm-table/lib/syntax.js:563:30)
    at go (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/util/create-tokenizer.js:136:13)
    at main (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/util/create-tokenizer.js:130:9)
    at Object.write (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/util/create-tokenizer.js:70:5)
    at continueFlow (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/initialize/document.js:119:15)
    at flowContinue (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/initialize/document.js:97:7)
    at flowStart (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/initialize/document.js:86:12)
    at go (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/util/create-tokenizer.js:136:13)
    at main (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/util/create-tokenizer.js:130:9)
    at Object.write (/Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous/node_modules/micromark/dist/util/create-tokenizer.js:70:5)

@ybiquitous
Copy link
Owner Author

The error of (#23 (comment)) is caused by remark@13.0.0 as a ybiq's dependency.

The commit 1e392a3 can fix it by installing remark-cli@10.0.0 explicitly.

$ npm ls remark
remark-preset-ybiquitous@0.0.5 /Users/masafumi.koba/git/ybiquitous/remark-preset-ybiquitous
├─┬ remark-cli@10.0.0
│ └── remark@14.0.1
└─┬ ybiq@13.5.1
  └─┬ remark-cli@9.0.0
    └── remark@13.0.0

@ybiquitous ybiquitous marked this pull request as ready for review August 15, 2021 07:34
"remark-lint-no-consecutive-blank-lines",
"remark-lint-no-duplicate-defined-urls",
"remark-lint-no-duplicate-headings",
"remark-lint-no-duplicate-headings",
Copy link
Owner Author

@ybiquitous ybiquitous Aug 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] remark-lint-no-duplicate-headings was duplicated. Importing plugins can detect such mistakes. (5abacdd)

@ybiquitous ybiquitous merged commit 41be1df into main Aug 15, 2021
@ybiquitous ybiquitous deleted the bump-remark-deps-and-esm-only branch August 15, 2021 07:37
ybiquitous added a commit that referenced this pull request Aug 15, 2021
This package now requires Node.js 12.20.0 or higher because of the ESM support only.
See #23
ybiquitous added a commit that referenced this pull request Aug 15, 2021
This package now requires Node.js 12.20.0 or higher because of the ESM support only.
See #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant