This repository has been archived by the owner on Mar 5, 2021. It is now read-only.
Fail if test files throw on load #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old behavior is to suppress the error and report success.
|
@yaymukund Thoughts on this change? Could save people's CI from reporting incorrectly. |
|
@yaymukund Still interested in getting this merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the files loaded into mocha throw an error on load (i.e, someone mistyped a
require), the current behavior is to silently catch the error and report success. I think this is actually a Grunt behavior (async tasks don't fail if they throw), but I don't think we'll have any luck changing how Grunt works.I also added a missing dev dependency to
package.jsonto get the tests working again.