Small pull request including bugfix and JSON filtering #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -478,7 +478,7 @@ void write_json_from_mat(MAT::Tree* T, std::string output_filename, std::vector< | |||
| { | |||
| "meta", { | |||
| {"title",title}, | |||
| {"filters",json::array({"country"})}, | |||
| {"filters",json::array({"country","userOrOld"})}, | |||
There was a problem hiding this comment.
I'm confused why country filtering wasn't already possible.
For some reason, the filters array in Usher auspice.json was empty. Have you checked that it now contains "country"? @jmcbroome
There was a problem hiding this comment.
You may have already spoken to Angie, but it appears that the UShER online interface hosted by UCSC uses a completely different codebase for this. I think you'll need to reach out to her to address filtering fields for JSONs yielded by hgPhyloPlace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR addresses an issue Angie found with my implementation of mutation masking and this issue about JSON line filtering. Local testing indicates that the latter change doesn't cause problems for locally generated files, but as I'm not directly familiar with the online UShER interface or the data it loads into the JSON output, @AngieHinrichs may want to verify that this behaves as expected and resolves the indicated issue as Roemer thinks it should.