Whitelist in matUtils extract + refactoring of introduce #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a quick request from @russcd this morning to whitelist samples that would otherwise be pruned or not included, added to matUtils extract. It takes a simple list of samples to always retain, not otherwise manipulable or combined with other selection logic.
Additionally, this PR includes some ongoing work on my part to clean up, refactor, and do some optimizations to matUtils introduce ahead of publication. It also includes a bugfix that will change exactly what clusters are called when I propagate it to the website. It is notably faster and should be somewhat better for memory as well.