Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to allow more flexible resize of partitions (needed by Agama) #1388

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Sep 12, 2024

Agama allows to specify what to do with the existing partitions during installation in a quite flexible way. That includes deleting, deleting if needed or resizing (both shrinking and growing) within certain min and max sizes.

The initial support for that is implemented at agama-project/agama#1599

This pull request includes all the changes needed to make that implementation possible.

@coveralls
Copy link

coveralls commented Sep 12, 2024

Coverage Status

coverage: 97.81% (+0.006%) from 97.804%
when pulling c0e4e86 on ancorgs:agama_resize
into 28fd260 on yast:master.

@ancorgs ancorgs force-pushed the agama_resize branch 3 times, most recently from a36b6b6 to 8e48662 Compare September 19, 2024 13:38
@ancorgs ancorgs changed the title Some draft stuff for handling resize of partitions at the Agama proposal Improvements to allow more flexible resize of partitions (needed by Agama) Sep 19, 2024
@ancorgs ancorgs force-pushed the agama_resize branch 2 times, most recently from fd0e879 to 65456bb Compare September 20, 2024 07:57
@ancorgs ancorgs marked this pull request as ready for review September 20, 2024 08:06
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ancorgs ancorgs merged commit b0dc35b into yast:master Sep 20, 2024
7 checks passed
Copy link

✅ Autosubmission job #10960612063 successfully finished
✅ Created submit request #1202231

ancorgs added a commit to agama-project/agama that referenced this pull request Sep 20, 2024
joseivanlopez#1 documented the approach to
follow for resizing partitions at Agama, based on the partitioning
config (a.k.a. the "profile").

The current pull request implements the basis of the described
management.

It depends on the improvements introduced at yast2-storage-ng by
yast/yast-storage-ng#1388

### Pending

Some aspects of partition growing are not fully handled. That's planned
for a future iteration and documented at
https://trello.com/c/opInsicQ/531-storage-profile-partition-growing
ancorgs added a commit to agama-project/agama that referenced this pull request Sep 22, 2024
yast/yast-storage-ng#1388 introduced a change in
the API of Y2Storage.

Agama was adapted at #1599, but one particular conversion was left
behind.

This PR fixes that omission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants