Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/py3 run #114

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Feature/py3 run #114

wants to merge 28 commits into from

Conversation

rachmadaniHaryono
Copy link

@rachmadaniHaryono rachmadaniHaryono commented Feb 28, 2017 •
edited
Loading

hi, i add test for this program along with some modification. here are the list of change that not shown on commit.

  • test
  • change in travis setting
    • add pandoc and python-eyed3
    • disable python2.6 and 3.2
      • python2.6: python -m flake8 not working.
      • python3.2: eyed3 is not working on travis-ci
  • change bin/instantmusic script: use simple python main function call. the code there is moved to proper place and tested.
  • change setup.cfg and setup.py: put them on root project folder.
  • package
    • add requirements-dev.txt for testing
    • add required package for program (eyed3, request)
  • program
    • simplify query_and_download : move part of the code to subfunction
    • rename makeRequest to make_request
    • catch error on python3

@rachmadaniHaryono
chg: dev: add python3 init.
9f26872
@rachmadaniHaryono
chg: dev: fix for python3.
b74d80a
@rachmadaniHaryono
chg: dev: fix flake8.
2e570a4
@rachmadaniHaryono
chg: dev: req-dev.txt for automated testing.
a65ae19
@rachmadaniHaryono
chg: dev: add setup.py
49b90a6
@rachmadaniHaryono
chg: dev: add package for testing.
5311825
@rachmadaniHaryono
chg: dev: add setup config.
a356765
@rachmadaniHaryono
chg: dev: change travis setting.
3a35f38
@rachmadaniHaryono
chg: dev: add pandoc to travis-ci
bd130c2
@rachmadaniHaryono
chg: dev: short line on setup.py
3e2dc63
@rachmadaniHaryono
chg: travis addons.
9ce6b1f
@rachmadaniHaryono
chg: dev: exclude installer for flake8 test.
d208246
@rachmadaniHaryono
chg: dev: remove pypandoc
9dd6c0b
@rachmadaniHaryono
chg: dev: merge setup and config
57b721b
@rachmadaniHaryono
chg: dev: short long line.
364432b
@rachmadaniHaryono
chg: dev: exclude eggs.
735e12d
@rachmadaniHaryono
chg: dev: rearranging files and folder for setup.py
a442223
@rachmadaniHaryono
chg: dev: add __init__.py
0714af5
@rachmadaniHaryono
chg: dev: fix flake8 test
2b04d58
@rachmadaniHaryono
fix: dev: travis ci flake8 error.
a05b455 
- disable test for python 2.6 (can't run `python -m flake8`)
- exclude line for flake8 test on python 3.2 (error E900)
@rachmadaniHaryono
chg: dev: add test file.
628767d
@rachmadaniHaryono
fix: test: remove unused init file.
57d8f7b
@rachmadaniHaryono
chg: dev: update travis
1a4bc2b 
- add eyed3 package.
  - use alternative name for eyed3.
- add request module.
- disable python3.2 test on travis-ci
  - eyed3 is not supported on python3.2
- use pytest instead of nose.
@rachmadaniHaryono
chg: dev: refactor print search result.
e1be36e
@rachmadaniHaryono
chg: dev: refactor pick from search result.
38234d5
@rachmadaniHaryono
chg: dev: refactor fix id3 tags.
96d8d58
@rachmadaniHaryono
fix: dev: get value after user pick.
2089711
@rachmadaniHaryono
new: test: test for simple function.
069ecfc
@rachmadaniHaryono rachmadaniHaryono mentioned this pull request May 18, 2017
Open
41 tasks
@rachmadaniHaryono rachmadaniHaryono mentioned this pull request May 26, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rachmadaniHaryono