Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor to new style and rename all conditions inside match.py so match can be fully used instead be + have #530

Open
yashaka opened this issue May 22, 2024 · 1 comment
Open

refactor to new style and rename all conditions inside match.py so match can be fully used instead be + have #530

yashaka opened this issue May 22, 2024 · 1 comment
Labels
2.0-mandatory

Comments

@yashaka
Copy link
Owner

yashaka commented May 22, 2024

subj
@yashaka yashaka changed the title rename all conditions inside match.py so match can be fully used instead be + have refactor to new style and rename all conditions inside match.py so match can be fully used instead be + have Jun 22, 2024
@yashaka
Copy link
Owner Author

yashaka commented Jun 22, 2024

This issue was renamed, because it's tightly coupled with complete refactoring of conditions...

This refactoring was actually started from commits from Commits on May 29, 2024 til Commits on Jun 22, 2024. And from now on, I will try to mark further commits as related to this ticket

yashaka added a commit that referenced this issue Jun 22, 2024
@yashaka
[#530] TEST: refactored have.exact_text coverage
60c18d6
yashaka added a commit that referenced this issue Jul 7, 2024
@yashaka
[#530] REFACTOR: be.blank, have.attribute, ...
9d99701 
... be.present_in_dom and be.visible (add _describe_actual_result), have.text and have.exact_text (reuse _ElementHasSomethingSupportingIgnoreCase), have.texts and have.exact_texts (reuse _CollectionHasSomethingSupportingIgnoreCase), have.tag and have.tag_containing,

* add _describe_actual_result support to Condition, Match, ...
* add some new TODOs and todos
  * see at least changelog for TODOs

NEW:
+ be._empty 4-in-1 experimental condition (over deprecated be.empty collection condition)
github-actions bot added a commit that referenced this issue Jul 7, 2024
@github-actions
[#530] REFACTOR: be.blank, have.attribute, ...
eab4094 
... be.present_in_dom and be.visible (add _describe_actual_result), have.text and have.exact_text (reuse _ElementHasSomethingSupportingIgnoreCase), have.texts and have.exact_texts (reuse _CollectionHasSomethingSupportingIgnoreCase), have.tag and have.tag_containing,

* add _describe_actual_result support to Condition, Match, ...
* add some new TODOs and todos
  * see at least changelog for TODOs

NEW:
+ be._empty 4-in-1 experimental condition (over deprecated be.empty collection condition)
yashaka added a commit that referenced this issue Jul 8, 2024
@yashaka
[#530] REFACTOR: disable description as keyword arg...
d1da03f 
... to Condition, Match, Query, Command. Now it's a positional only. It's kind of a prep step to potential renaming it to name.

Also leave some new TODOs on Condition/Match args design. And made tiny fixes in Condition docstring examples.
yashaka added a commit that referenced this issue Jul 9, 2024
@yashaka
[#530] REFACTOR: rename description to name..
fd0ad5e 
... in Condition, Match, Query, Command and co.
github-actions bot added a commit that referenced this issue Jul 9, 2024
@github-actions
[#530] REFACTOR: rename description to name..
785668b 
... in Condition, Match, Query, Command and co.
yashaka added a commit that referenced this issue Jul 9, 2024
@yashaka
[#530] REFACTOR: text and size conditions
8d7fa83 
condition aliases and new conditions:
- collection conditions
  - `have.size(int).or_more` as alias to `have.size_greater_than_or_equal(int)`
  - `have.size(int).or_less` as alias to `have.size_less_than_or_equal(int)`
- element conditions
  - `have.size(dict_of_element_size)`
- browser conditions
  - `have.size(dict_of_browser_size)`

add
- config._match_only_visible_elements_texts
  - `True` by default
yashaka added a commit that referenced this issue Jul 10, 2024
@yashaka
[#530]: filter out for visibility in have size via config
58cae14 
+
TEST: finalize disabling have size test for elements
yashaka added a commit that referenced this issue Jul 10, 2024
@yashaka
[#530] TEST: finalize tests for previous refactoring
a3985aa
yashaka added a commit that referenced this issue Jul 11, 2024
@yashaka
[#530] REFACTOR: condition names as callables by entity type...
17ed83d 
 ... to support name per entity type
github-actions bot added a commit that referenced this issue Jul 11, 2024
@github-actions
[#530] REFACTOR: condition names as callables by entity type...
48974a1 
 ... to support name per entity type
yashaka added a commit that referenced this issue Jul 11, 2024
@yashaka
[#530] REFACTOR: match.url*
da10bdb 
TODOS in changelog:
* should we support ignorecase on asserting urls too?
* should we make ingorecase optionally default for all conditions supporting it?
yashaka added a commit that referenced this issue Jul 12, 2024
@yashaka
[#530] TEST: clean tests from pytest.exit
0960c28
github-actions bot added a commit that referenced this issue Jul 12, 2024
@github-actions
[#530] TEST: clean tests from pytest.exit
d8843d9
yashaka added a commit that referenced this issue Jul 12, 2024
@yashaka
[#530] TEST: finalize match.size tests
292dcaf
yashaka added a commit that referenced this issue Jul 12, 2024
@yashaka
[#530] REFACTOR: support ignore_case on match.url*
9a32470
@yashaka yashaka mentioned this issue Jul 14, 2024
Open
yashaka added a commit that referenced this issue Jul 14, 2024
@yashaka
[#530] NEW: support ignore_case as config option
615111a 
[#537] TEST: cover value like conditions with ignore_case tests
github-actions bot added a commit that referenced this issue Jul 14, 2024
@github-actions
[#530] NEW: support ignore_case as config option
6bbb6dd 
[#537] TEST: cover value like conditions with ignore_case tests
yashaka added a commit that referenced this issue Jul 15, 2024
@yashaka
[#530] REFACTOR: rename match.text to match.text_containing...
c4389ac 
... to improve readability in context of match.* phrasing
github-actions bot added a commit that referenced this issue Jul 15, 2024
@github-actions
[#530] REFACTOR: rename match.text to match.text_containing...
cf4dc7d 
... to improve readability in context of match.* phrasing
yashaka added a commit that referenced this issue Jul 15, 2024
@yashaka
[#530] REFACTOR: match.title*, match.tabs_number*
640a6d8 
[#537] DOCS: log todo on potential property based impl. (similar to .ignore_case prop)
yashaka added a commit that referenced this issue Jul 15, 2024
@yashaka
[#530] TEST: fix match.tabs_number* tests for CI
18cd27b
yashaka added a commit that referenced this issue Jul 17, 2024
@yashaka
[#530] FIX: conditions that override falsy_exceptions...
eb62e5a 
... by adding missed AssertionError handling
yashaka added a commit that referenced this issue Jul 17, 2024
@yashaka
[#530] TEST: more attribute..value_containing.each cases
54a4bf5
yashaka added a commit that referenced this issue Jul 17, 2024
@yashaka
[#530] REFACTOR: match.native_property and match.css_property impl
8cb7098
yashaka added a commit that referenced this issue Jul 17, 2024
@yashaka
[#530] REFACTOR: rename config._ignore_case ...
d4222d9 
... to config._match_ignoring_case because browser.with(_ignore_case=True).element(by.text(...)) will confuse...
yashaka added a commit that referenced this issue Jul 19, 2024
@yashaka
[#530] REFACTOR: privatize Condition actual & by, make test positiona…
418335b 
…l + ...

... DOCS: update condition.py docstrings guides
yashaka added a commit that referenced this issue Jul 19, 2024
@yashaka
[#530] TEST: remove test= style according to prev commit
67c2cce
yashaka added a commit that referenced this issue Jul 19, 2024
@yashaka
[#530] TEST: ensure passing Condition to Match as by works...
0ed4982 
... in case of custom falsy_exceptions set for Condition
yashaka added a commit that referenced this issue Jul 20, 2024
@yashaka
[#530] REFACTOR: ... over (...,) as one_or_more, etc.
71dd4c9
yashaka added a commit that referenced this issue Jul 20, 2024
@yashaka
[#530] NEW: config._match_placeholder_to_match_elements
abab8a4
yashaka added a commit that referenced this issue Jul 21, 2024
@yashaka
[#505] REFACTOR: postpone All descriptor filtering :( + ...
9f73818 
[#530] NEW: match.checked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0-mandatory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yashaka