Glide update and comment out usage of grpc-opentracing until fixed #996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the situation:
metadata.NewContext
twice, the second call overrides the first, and metadata is lost Metadata context changes are not backwards compatible/break existing code grpc/grpc-go#1219I commented out usages of grpc-opentracing for now until grpc-ecosystem/grpc-opentracing#29 is merged, and changed grpc-go in glide to be pinned to minor versions.
grpc-opentracing doesn't actually have releases either, so this makes it more problematic. We may want to review using it altogether.