feat: Opt for concatenation instead of using fmt.Sprintf

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## [Unreleased]
 - Upgraded go version to 1.21, set toolchain version.
 - Reverted rpc-caller-procedure value setting.
+- Performance improvement in the tchannel transport by reducing the number of allocations.
 
 ## [1.72.1] - 2024-03-14
 - tchannel: Renamed caller-procedure header from `$rpc$-caller-procedure` to `rpc-caller-procedure`.

pkg/procedure/procedure.go

@@ -22,19 +22,20 @@
 package procedure
 
 import (
-	"fmt"
 	"strings"
 )
 
+const _separator = "::"
+
 // ToName gets the procedure name we should use for a method
 // with the given service name and method name.
 func ToName(serviceName string, methodName string) string {
-	return fmt.Sprintf("%s::%s", serviceName, methodName)
+	return serviceName + _separator + methodName
 }
 
 // FromName gets the service name and method name from a procdure name.
 func FromName(name string) (serviceName string, methodName string) {
-	parts := strings.SplitN(name, "::", 2)
+	parts := strings.SplitN(name, _separator, 2)
 	if len(parts) == 1 {
 		return parts[0], ""
 	}

pkg/procedure/procedure_test.go

@@ -51,3 +51,12 @@ func TestProcedureNameAndSplit(t *testing.T) {
 		assert.Equal(t, tt.Method, m)
 	}
 }
+
+func BenchmarkToName(b *testing.B) {
+	alphabet := "abcdefghijklmnopqrstuvwxyz"
+	b.ReportAllocs()
+	b.ResetTimer()
+	for i := 0; i < b.N; i++ {
+		ToName(alphabet, alphabet)
+	}
+}