Override default peer options based on args #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If defaults sets the hosts file, but args sets a single peer, the final options should only contain the single peer. If both are set, yab returns an error. This is required if we want to set a default peer list in a global config that is only used when the user doesn't override the peer in any way.
|
@prashantv, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blampe to be a potential reviewer |
|
|
||
| // Clear default peers if the user has specified peer options in args. | ||
| if len(argsOnly.TOpts.HostPorts) > 0 && defaults.TOpts.HostPortFile != "" { | ||
| defaults.TOpts.HostPortFile = "" |
There was a problem hiding this comment.
Do you really need the second check? If you always set HostPortFile to "" when HostPorts is non-empty, you get the same result.
|
👍 |
ZymoticB
pushed a commit
to ZymoticB/yab
that referenced
this pull request
Aug 26, 2016
If defaults sets the hosts file, but args sets a single peer, the final options should only contain the single peer. If both are set, yab returns an error. This is required if we want to set a default peer list in a global config that is only used when the user doesn't override the peer in any way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If defaults sets the hosts file, but args sets a single peer, the
final options should only contain the single peer. If both are set,
yab returns an error.
This is required if we want to set a default peer list in a global
config that is only used when the user doesn't override the peer in
any way.