Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributing link #7851

Closed
wants to merge 3 commits into from
Closed

Fix contributing link #7851

wants to merge 3 commits into from

Conversation

NoriSte
Copy link

@NoriSte NoriSte commented Jan 28, 2020

Summary
The yarn 2 website does not redirect the org/contributing URL.

Copy link
Contributor

@olingern olingern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want two different links. It may be a little confusing at the moment:

Contributing to v1
https://legacy.yarnpkg.com/en/docs/getting-started

Contributing to v2
https://yarnpkg.com/en/org/contributing

@olingern
Copy link
Contributor

Also, I should note that the cookies ( I suppose that's what's doing the legacy redirect) seem kind of sticky and I can't directly navigate to the v2 docs I've I've chosen to go to the legacy docs in the past.

ping @Daniel15 @arcanis

@PierreBerger
Copy link

There is also the Contributing link of the README to replace.

@NoriSte
Copy link
Author

NoriSte commented Feb 3, 2020

Ok (for the README) but what about the @oligot note?
More: is the "legacy" third-level domain going to be renamed "classic"?

@Daniel15
Copy link
Member

Daniel15 commented Feb 3, 2020

@NoriSte The domain has already been changed... I might set up a 301 redirect from legacy. to classic. at some point. Currently both domains still work.

@NoriSte
Copy link
Author

NoriSte commented Feb 7, 2020

The README.md' link goes to the CONTRIBUTING.md file where I've added both the v1 and the v2 links 😊

CONTRIBUTING.md Outdated Show resolved Hide resolved
@Ende93
Copy link

Ende93 commented Apr 28, 2020

@NoriSte Seem like the old request change blocks the merge, can you resolve it?

@NoriSte
Copy link
Author

NoriSte commented Apr 28, 2020

Hi @Ende93 It's not clear to me why the continuous-integration/appveyor/pr build is failing, could you help me, please?
I don't understand how the

FAIL __tests__\commands\add.js (83.861s)
  ● add with --ignore-workspace-root-check shouldn't fail on the workspace root
    Error: expect(received).toBe(expected) // Object.is equality

test could be related to my changes...

@Ende93
Copy link

Ende93 commented Apr 28, 2020

I saw the lastest commit(Fixes empty yarnrc files) also failed the same test, so it's ok.

@NoriSte
Copy link
Author

NoriSte commented Apr 28, 2020

Ok, let me know if you need me adding more changes 😊

@Ende93
Copy link

Ende93 commented Apr 29, 2020

Please resolve the request.
image

@Andrew836-dev
Copy link

This seems like the preferred solution to these open issues
#8426 #8350 #8335 #7950
and these open pull requests
#8427 #8365 #8356 #8336 #8213 #8189 #8159 #7952 #7494

@arcanis @olingern

@NoriSte
Copy link
Author

NoriSte commented Feb 1, 2021

I left following the PR because it's not clear to me if I have to do something more or not... 🤔

@merceyz
Copy link
Member

merceyz commented Jan 17, 2022

Fixed in 0a121f6

@merceyz merceyz closed this Jan 17, 2022
@NoriSte NoriSte deleted the patch-1 branch January 18, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants