-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix contributing link #7851
Fix contributing link #7851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want two different links. It may be a little confusing at the moment:
Contributing to v1
https://legacy.yarnpkg.com/en/docs/getting-started
Contributing to v2
https://yarnpkg.com/en/org/contributing
There is also the Contributing link of the README to replace. |
Ok (for the README) but what about the @oligot note? |
@NoriSte The domain has already been changed... I might set up a 301 redirect from legacy. to classic. at some point. Currently both domains still work. |
The README.md' link goes to the CONTRIBUTING.md file where I've added both the v1 and the v2 links 😊 |
@NoriSte Seem like the old request change blocks the merge, can you resolve it? |
Hi @Ende93 It's not clear to me why the
test could be related to my changes... |
I saw the lastest commit(Fixes empty yarnrc files) also failed the same test, so it's ok. |
Ok, let me know if you need me adding more changes 😊 |
I left following the PR because it's not clear to me if I have to do something more or not... 🤔 |
Fixed in 0a121f6 |
Summary
The yarn 2 website does not redirect the
org/contributing
URL.