Fixes offline mirror filename calculation for scoped packages URLs in the taobao npm registry

[Axure]

Summary

The taobao registry gives tarball urls for scoped packages in formats like https://registry.npm.taobao.org/@types/prop-types/download/@types/prop-types-15.7.2.tgz, which cannot be parsed by the current regex /\/(?:(@[^/]+)(?:\/|%2f))?[^/]+\/(?:-|_attachments)\/(?:@[^/]+\/)?([^/]+)$/. The result will thus fallback to prop-types-15.7.2.tgz which conflicts with the cache for the package prop-types. This will result in checksum mismatch.

Fix #7532.

Test plan

Added a test in __tests__/fetchers.js.

[Axure]

Lint seems to have failed on master since #7512

[Axure]

@arcanis Please have a look?

[PLQin]

I also had this problem:

error https://registry.npm.taobao.org/@types/events/download/@types/events-3.0.0.tgz: Integrity check failed for "@types/events"
(computed integrity doesn't match our records, got "sha1-KGLz9Yqaf3w+eNefEw3U1xwlwqc=")

[xyy94813]

I got same issue with events and @types/events.

[xiaoxiangmoe]

@arcanis Please have a look. Thanks.

[xyy94813]

I think it is the most easy way to resolve this issue.

[jpli]

This would fix my problem with react-router-dom and @types/react-router-dom.

[Axure]

Is yarn 1 no longer maintained?

[kidonng]

Is yarn 1 no longer maintained?

https://dev.to/arcanis/introducing-yarn-2-4eh1#what-will-happen-to-the-legacy-codebase

Yarn 1.22 will be released next week. Once done, the 1.x branch will officially enter maintenance mode - meaning that it won't receive further releases from me except when absolutely required to patch vulnerabilities. New features will be developed exclusively against Yarn 2.

I doubt if this is still an issue on Yarn 2 because it seems related code has been refactored:

https://github.com/yarnpkg/berry/blob/master/packages/plugin-http/sources/TarballHttpFetcher.ts#L7-L16

https://github.com/yarnpkg/berry/blob/master/packages/plugin-http/sources/constants.ts#L1-L3

[codering]

Plz merge this.

[UNDERCOVERj]

i have the same problem

[xiaoxiangmoe]

Is yarn 1 no longer maintained?

[JdaieLin]

reviewed