Do not log err.message of ProcessTermErrors if silent
#7472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Of course the tests don't fail on my machine. 🙄 |
|
Well, still looks like For now, I just unset Still, everything red bc the RequestManager times out/cert invalid. Disappointing for a first time contrib 😞 🤷♀ |
Apologies - my attention is like at 99% focused on the v2 at this point, so I get less time to fix (or even see) this kind of things 😕 Your contrib looks fine apart from the CA things that are on us, so I'll plan it for the 1.18. Thanks! |
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
* Do not log `err.message` of `ProcessTermError`s if silent Fixes yarnpkg#5359 * Ensure `YARN_SILENT=0` by default in the integration tests
VincentBailly
pushed a commit
to VincentBailly/yarn
that referenced
this pull request
Jun 10, 2020
* Do not log `err.message` of `ProcessTermError`s if silent Fixes yarnpkg#5359 * Ensure `YARN_SILENT=0` by default in the integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5359
If sub commands called via
yarn runfail yarn typically logserror Command failed with exit code 1.even if--silentis requested basically because a failing command throws (or rethrows) itself instead of just returning this failure as valid output.This is the simplest patch to suppress this output.