Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fixture certificates to prevent false negatives during testing #7457

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Update fixture certificates to prevent false negatives during testing #7457

merged 2 commits into from
Aug 16, 2019

Conversation

eilgin
Copy link
Contributor

@eilgin eilgin commented Aug 3, 2019

Summary

Fixes #7436 and should also fix the CI tests!

Test plan

yarn test-only __tests__/util/request-manager.js

It should output:

 PASS  __tests__/util/request-manager.js
...

eilgin pushed a commit to eilgin/yarn that referenced this pull request Aug 3, 2019
Adding yarnpkg#7457 to CHANGELOG.md
f922370
@eilgin eilgin mentioned this pull request Aug 3, 2019
Open
@buildsize
Copy link

buildsize bot commented Aug 3, 2019

File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.18 MB 1.18 MB -52 bytes (0%)
yarn-[version].js 4.85 MB 4.85 MB -12 bytes (0%)
yarn-legacy-[version].js 5.05 MB 5.05 MB -12 bytes (0%)
yarn-v[version].tar.gz 1.18 MB 1.19 MB 1.88 KB (0%)
yarn_[version]all.deb 868.44 KB 868.75 KB 322 bytes (0%)

@rockwyc992
Copy link

Great, but why not still use 4096 bits key size?

@eilgin
Copy link
Contributor Author

eilgin commented Aug 6, 2019 •
edited
Loading

Great, but why not still use 4096 bits key size?

My bad. I've used the default key size value (e.g. 2048 on my machine) instead of the previous size. I've fixed that!

@rockwyc992
Copy link

LGTM, have tested with debian 10.0 with following config.

# /etc/ssl/openssl.cnf
MinProtocol = TLSv1.2
CipherString = DEFAULT@SECLEVEL=2

@rockwyc992 rockwyc992 mentioned this pull request Aug 6, 2019
Closed
@krzysztof-pawlik-gat krzysztof-pawlik-gat mentioned this pull request Aug 6, 2019
Closed
@arcanis
Copy link
Member

arcanis commented Aug 16, 2019

That's awesome, thanks!

@arcanis arcanis merged commit 1a57117 into yarnpkg:master Aug 16, 2019
@eilgin eilgin deleted the update-ca branch August 16, 2019 14:06
VincentBailly pushed a commit to VincentBailly/yarn that referenced this pull request Jun 10, 2020
@eilgin
Update fixture certificates to prevent false negatives during testing (…
98baa60 
…yarnpkg#7457)

* Update fixture certificates to prevent false negatives during testing

* Adding yarnpkg#7457 to CHANGELOG.md
VincentBailly pushed a commit to VincentBailly/yarn that referenced this pull request Jun 10, 2020
@eilgin @VincentBailly
Update fixture certificates to prevent false negatives during testing (…
2737eff 
…yarnpkg#7457)

* Update fixture certificates to prevent false negatives during testing

* Adding yarnpkg#7457 to CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run yarn test would be failed with error: SSL_CTX_use_certificate:ca md too weak
3 participants
@eilgin @rockwyc992 @arcanis