Add a failing test for version conflicts #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmark
force-pushed
the
add_test_for_conflicts
branch
from
0238a05
to
f1de0ed
Compare
bestander
reviewed
Jul 1, 2017
| { | ||
| "version": "0.0.1", | ||
| "dependencies": { | ||
| "left-pad": ">=0.0.1" |
|
Don't think so I think >=0.0.1 and 1.0.0 should not conflict? This test shows that they do conflict. (looks like >=0.0.1 resolves to a hard pin for whatever the latest version is?) This behaviour was not present prior to 0.27.0 |
magicmark
force-pushed
the
add_test_for_conflicts
branch
from
f1de0ed
to
6476dc5
Compare
|
@bestander Skipped the test, added comment linking to issue. I'll have a go at #3778 :) |
|
Awesome!
…On Sun, Jul 2, 2017 at 10:19 AM Mark Larah ***@***.***> wrote:
@bestander <https://github.com/bestander> Skipped the test, added comment
linking to issue.
I'll have a go at #3778 <#3778> :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3779 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACBdWO0zurtbtqml4vzAVkbRQeojzVHMks5sJ9E3gaJpZM4OLEIW>
.
|
|
Merged this, ping me on a fix :) |
BYK
pushed a commit
that referenced
this pull request
Sep 22, 2017
…el dependency (#4488) **Summary** Fixes #3780, and makes the failing test from #3779 passing. As a final step of package resolution, for each dependency we check whether any version satisfies all resolved version ranges. **Test plan** Fixes an existing (failing) test: "unbound transitive dependencies should not conflict with top level dependency"
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…el dependency (yarnpkg#4488) **Summary** Fixes yarnpkg#3780, and makes the failing test from yarnpkg#3779 passing. As a final step of package resolution, for each dependency we check whether any version satisfies all resolved version ranges. **Test plan** Fixes an existing (failing) test: "unbound transitive dependencies should not conflict with top level dependency"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a failing test to highlight the issue the issue here #3780 https://github.com/mxmul/yarn_flat_regression
tl;dr:
yarn fails when doing
--flatwith the following:(yarn version: 0.27.1)
(this seems to be a regression introduced in 0.27.0, this worked in 0.26.1)
Test plan
This is a test only change.
This test is currently failing because it's prompting for a resolution, with the following stacktrace